[oe] [PATCH] base.bbclass: fix soc-family test

Phil Blundell philb at gnu.org
Thu Sep 9 09:30:09 UTC 2010


On Thu, 2010-09-09 at 09:11 +0200, Frans Meulenbroeks wrote:
> 2010/9/2 Frans Meulenbroeks <fransmeulenbroeks at gmail.com>:
> > -                if this_soc_family and not re.match(need_machine, this_soc_family):
> > +                if (this_soc_family and not re.match(need_machine, this_soc_family)) or not this_soc_family:
> >                     raise bb.parse.SkipPackage("incompatible with machine %s" % this_machine)

I am still far from convinced that this hunk of SOC_FAMILY code is
desirable to have in the first place but, if it's going to stay there,
clearly it should be fixed so that it doesn't cause problems for
non-users.  

So, yes, your patch looks fine to me.

p.






More information about the Openembedded-devel mailing list