[oe] [PATCH] base.bbclass: fix soc-family test

[Frans Meulenbroeks]

2010/9/9 Maupin, Chase <chase.maupin at ti.com>:

>>
>> I'm not too sure on the usefulness of it either, but there is some
>> breakage so we should either revert the patch or fix it.
>>
>> Actually the SOC_FAMILY got pushed before the review was concluded.
>> Technically it got the ack's but the discussion was still ongoing when
>> this was pushed.
>> What also makes it fishy is that all acks are from the same company
>> (which is the same one as the person who submitted the patch):
>>
>> Signed-off-by: Chase Maupin <chase.maupin at ti.com>
>> Acked-by: Denys Dmytriyenko <denys at ti.com>
>> Acked-by: Koen Kooi <k-kooi at ti.com>
>> Signed-off-by: Koen Kooi <koen at openembedded.org>
>>
>> I would suggest modifying the commit policy disallowing these kind of
>> things, saying the two Ack's must be from two developers not
>> affiliated with the same company.
>> (actually we might even want to take it further and saying that global
>> changes that affect everyone would require ACK's from developers from
>> more than one distro).
>>
>> Question to the TSC: should the SOC_FAMILY patch be reverted and put
>> on hold until there is agreement whether or not we want this?
>
> Frans,
>
> As the person who submitted this change I'd like to ask that it not be reverted.  I am using it currently so that when defining COMPATIBLE_MACHINE for recipes targeted at OMAP3 devices I do not have to keep a rolling list of all the various OMAP3 devices.  This can quickly become:
>
> COMPATIBLE_MACHINE = "dm37x-evm|am37x-evm|omap3evm|am3517-evm|beagleboard|......"
>
> Instead by allowing SOC_FAMILY to be used as a COMPATIBLE_MACHINE this can be handled cleanly with:
>
> COMPATIBLE_MACHINE = "omap3"
>
> Please consider this use case.  I would much prefer if your fix was put into the base.bbclass than if this were removed.
>

Chase,

I understand your use case.
The major concern I see is the overlap with MACHINE_CLASS.
Anyway, I have no real objections against SOC_FAMILY.
The only observation is that it has been introduced a little bit
hastily without the community reaching consensus.

Frans.

PS: thanks for the ack that arrived while I was typing this
PPS: wrt COMPATIBLE_MACHINE: I think it is possible to use wildcards,
so *if* the machines with omap3 get that as a prefix it could also be
used
(and yes: this is just an alternate option, and I see the con's of it)