[oe] [PATCHv2] jpeg_8b: Allow using older versions of automake

[Maupin, Chase]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org
> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
> Paul Menzel
> Sent: Friday, September 10, 2010 2:52 PM
> To: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [PATCHv2] jpeg_8b: Allow using older versions of
> automake
> 
> Dear Chase,
> 
> 
> Am Freitag, den 10.09.2010, 15:20 -0400 schrieb Denys Dmytriyenko:
> > On Fri, Sep 10, 2010 at 01:02:20PM -0500, Chase Maupin wrote:
> > > From: Chase <chase at chase-laptop.(none)>
> 
> please set up Git on your laptop with the following command.
> 
>     git config user.name Chase Maupin
>     git config user.email chasemaupin03 at gmail.com

Paul,

I'm not sure how that From line got in this mail.  My other patches don't have it.  I have my git config set for user.email chase.maupin at ti.com (even though I send through a gmail account because I'm not trying to hide that these patches are from someone at TI).  The weird thing is that my laptop is my Windows PC and I don't send patches from it.  Perhaps this snuck in because I responded to the thread from my Windows PC (outlook).

> 
> > > * Added patch to allow using older versions of automake such
> > >   as 1.10.3 when building jpeg version 8b.
> > > * Only use the AM_SILENT_RULES if it is available.
> > >
> > > Signed-off-by: Chase Maupin <chase.maupin at ti.com>
> >
> > Acked-by: Denys Dmytriyenko <denis at denix.org>
> 
> To get the stats right, maybe the one who is pushing this can fix this
> up by deleting the From: line in the message body.
> 
> Thanks,
> 
> Paul
> 
> > > ---
> > >  ...igure-make-jpeg-work-with-older-autotools.patch |   30
> ++++++++++++++++++++
> > >  recipes/jpeg/jpeg_8b.bb                            |    7 +++-
> > >  2 files changed, 35 insertions(+), 2 deletions(-)
> > >  create mode 100644 recipes/jpeg/jpeg-8b/0001-configure-make-jpeg-
> work-with-older-autotools.patch
> > >
> > > diff --git a/recipes/jpeg/jpeg-8b/0001-configure-make-jpeg-work-with-
> older-autotools.patch b/recipes/jpeg/jpeg-8b/0001-configure-make-jpeg-
> work-with-older-autotools.patch
> > > new file mode 100644
> > > index 0000000..dd6fd52
> > > --- /dev/null
> > > +++ b/recipes/jpeg/jpeg-8b/0001-configure-make-jpeg-work-with-older-
> autotools.patch
> > > @@ -0,0 +1,30 @@
> > > +From e9e77ee999553f9b94de0288688a0bdc60b92e0f Mon Sep 17 00:00:00
> 2001
> > > +From: Chase Maupin <chase.maupin at ti.com>
> > > +Date: Tue, 17 Aug 2010 08:30:56 -0500
> > > +Subject: [PATCH] configure: make jpeg work with older autotools
> > > +
> > > +* Only use the AM_SILENT_RULES variable if it is defined.  Older
> > > +  versions of automake don't support this option.
> > > +
> > > +Signed-off-by: Chase Maupin <chase.maupin at ti.com>
> > > +---
> > > + configure.ac |    3 ++-
> > > + 1 files changed, 2 insertions(+), 1 deletions(-)
> > > +
> > > +diff --git a/configure.ac b/configure.ac
> > > +index 96da13b..9a58c51 100644
> > > +--- a/configure.ac
> > > ++++ b/configure.ac
> > > +@@ -26,7 +26,8 @@ AM_INIT_AUTOMAKE([-Wall -Werror ansi2knr no-dist
> foreign])
> > > + # Make --enable-silent-rules the default.
> > > + # To get verbose build output you may configure
> > > + # with --disable-silent-rules or use "make V=1".
> > > +-AM_SILENT_RULES([yes])
> > > ++# only use if available
> > > ++m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
> > > +
> > > + # This is required when using the de-ANSI-fication feature.
> > > + AM_C_PROTOTYPES
> > > +--
> > > +1.7.0.4
> > > +
> > > diff --git a/recipes/jpeg/jpeg_8b.bb b/recipes/jpeg/jpeg_8b.bb
> > > index 4251ca6..688dcd8 100644
> > > --- a/recipes/jpeg/jpeg_8b.bb
> > > +++ b/recipes/jpeg/jpeg_8b.bb
> > > @@ -2,12 +2,15 @@ DESCRIPTION = "libjpeg is a library for handling the
> JPEG (JFIF) image format."
> > >  LICENSE = "jpeg"
> > >  SECTION = "libs"
> > >  PRIORITY = "required"
> > > -PR = "r0"
> > > +PR = "r1"
> > >
> > >  # TODO: really needed?
> > >  RPROVIDES_${PN} = "jpeg"
> > >
> > > -SRC_URI = "http://www.ijg.org/files/jpegsrc.v${PV}.tar.gz"
> > > +SRC_URI = "\
> > > +    http://www.ijg.org/files/jpegsrc.v${PV}.tar.gz \
> > > +    file://0001-configure-make-jpeg-work-with-older-autotools.patch \
> > > +    "
> > >  S = "${WORKDIR}/jpeg-${PV}"
> > >
> > >  inherit autotools
> > > --
> > > 1.7.0.4