[oe] [PATCH] insane.bbclass: Enable the insane.bbclass for everyone in a warning mode
Koen Kooi
k.kooi at student.utwente.nl
Sun Sep 12 11:50:30 UTC 2010
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12-09-10 11:52, Holger Freyther wrote:
>
> Make conf/bitbake.conf load conf/insane.conf that will INHERIT the
> insane.bbclass. Remove the INHERIT from the distros currently using
> insane.bbclass. Change insane.bbclass to check QA_FATAL to see if errors
> are allowed to be fatal, make SHR/Kaelios and Angstrom use that new
> flag to continue having fatal QA Errors.
>
> Signed-off-by: Holger Hans Peter Freyther <zecke at selfish.org>
Looks good to me, but a slight nit-pick:
+#log QA errors
QA_LOG = "1"
+QA_FATAL = "1"
Can you change the comment to something like:
# Log QA errors and abort the build when encountering them
So that it's clear what the 2 vars do?
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMjL6GMkyGM64RGpERAu6nAJ9YVJtjYLE4RJGT8vJaFtCUUpNHLwCfQUXn
bWPfFuQSJMkJMmjkg1j7gAY=
=Chyt
-----END PGP SIGNATURE-----
More information about the Openembedded-devel
mailing list