[oe] [PATCH] driftnet: fix recipe to work with a modern build system

Khem Raj raj.khem at gmail.com
Mon Sep 13 18:25:14 UTC 2010


On Fri, Sep 10, 2010 at 6:46 PM, Sean Cross <sean at chumby.com> wrote:
> The driftnet recipe seems to be patching the Makefile to explicitly specify a compiler called arm-linux-gcc, and to remove the dependency on pkg-config.  I believe both of these are obsolete practices now.
>
> Signed-off-by: Sean Cross <sean at chumby.com>

looks ok.

Acked-by: Khem Raj <raj.khem at gmail.com>

> ---
>  recipes/driftnet/driftnet-0.1.6/arm.patch |   13 +------------
>  1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/recipes/driftnet/driftnet-0.1.6/arm.patch b/recipes/driftnet/driftnet-0.1.6/arm.patch
> index 340a6cf..c5b7155 100644
> --- a/recipes/driftnet/driftnet-0.1.6/arm.patch
> +++ b/recipes/driftnet/driftnet-0.1.6/arm.patch
> @@ -5,7 +5,7 @@
>
>  # Compiler to use.
>  -#CC = gcc
> -+CC = arm-linux-gcc
> ++CC ?= arm-linux-gcc
>
>  # Basic compiler, linker flags; should not need any changes.
>  CFLAGS += -g -Wall
> @@ -17,17 +17,6 @@
>  #LDFLAGS += -L/path/to/libpcap.so
>
>  # Required on Linux to get BSDish definitions of the TCP/IP structs.
> -@@ -31,8 +31,8 @@
> -
> - # Optional C compiler and linker flags. Typical driftnet builds have support
> - # for displaying captured images in an X window, and need the following flags:
> --CFLAGS  += `gtk-config --cflags`
> --LDLIBS  += -ljpeg -lungif `gtk-config --libs`
> -+CFLAGS  += -I$(STAGING_INCDIR)/glib-2.0 -I$(STAGING_INCDIR)/gtk-2.0 -I$(STAGING_INCDIR)/../lib/gtk-2.0/include -I$(STAGING_INCDIR)/atk-1.0
> -+LDLIBS  += -ljpeg -lungif -lgtk-x11-2.0 -lgdk-x11-2.0 -rdynamic -lgmodule-2.0 -lglib-2.0 -ldl -lXext -lX11 -lm
> -
> - # Alternatively, you can build a version of driftnet which can only be used
> - # in `adjunct' mode as the back end for some other image-processing program. To
>  @@ -81,13 +81,13 @@
>        ( echo '.\" DO NOT EDIT THIS FILE-- edit driftnet.1.in instead' ; sed s/@@@VERSION@@@/$(VERSION)/ ) < driftnet.1.in > driftnet.1
>
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



-- 
-Khem




More information about the Openembedded-devel mailing list