[oe] [PATCH] nodejs: replaced v0.2.0 with v0.2.1

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Thu Sep 16 19:54:41 UTC 2010


2010/9/16 AJ ONeal <coolaj86 at gmail.com>:
>>
>> Could please pay more attention next time? This introduces 2 big
>> regressions that were previously fixed by:
>>
>> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=3967caeb51d7427980e06fd8b6e23c8fdc75e791
>>
>
> I'd like to make note of a few things
>
>   - From the feedback I got - "please correct and submit again" - I was
>   unaware that my prior submission been accepted.
>   (I created this patch on a different machine with a fresh copy of oe and
>   I just copied my old recipe over, not noticing it was in - my mistake)
>
>   - Who is the maintainer of this recipe? I assumed that I was since I
>   submitted it.

I'd say yes.

>   I thought the policy was something along the lines of letting the
>   maintainer know of changes made.

The policy is here: http://wiki.openembedded.net/index.php/Commit_Policy

It says:
 * It's fine to fix a recipe you don't maintain, but its polite to talk to
   any else actively maintaining that recipe. Try to contact the maintainer
   or, if no maintainer is listed, send a note to the OE developer mailing list

but apparently some people feel the rules do not apply to them
(although they bitch others if they do deviate from the rules)

>   Granted, had I noticed earlier that it was in the tree I would have I
>   would have modified the files in the tree rather blindly copying my stuff
>   in.
>
>   - I posted to the list about the oe_runmake install issue and didn't get
>   a response, yet the correction was made and submitted.
>
>
> That said, thanks for the help; I appreciate it. I'll figure out how OE
> policy and such works as time goes on. Forgive me of my ignorance as I
> learn.

Welcome to OE.Your contribution is really appreciated.
And we all make mistakes and we all were in your situation at some
point in time.
You'll learn it (and feel free to ask advice here or on irc)

And most of all: have fun!
Frans.




More information about the Openembedded-devel mailing list