[oe] [PATCH] Remove dbus support from wvstreams-4.6 because it breaks the build

[Paul Menzel]

Dear Thilo,


please adhere to the commit policy regarding the commit summary, i. e.,
it has to start with the package name.

wvstreams-4.6: remove DBus support, because configure.ac is faulty.

Am Dienstag, den 28.09.2010, 09:28 +0200 schrieb Thilo Fromm:
> If wvstreams is configured with DBus support enabled (by not providing
> --without-dbus) the the build fails at link time as libdbus cannot be
> found:
> 
> | ./CXX -c dbus/wvdbusconn
> | ./CXX -c dbus/wvdbusmarshal
> | ./CXX -c dbus/wvdbusmsg
> | ./CXX -c dbus/wvdbusserver
> | linking libwvdbus.so...
> | arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or
> directory

Can your editor be configured to not add line breaks to quotes? I would
prefer that.

> | make: *** [libwvdbus.so] Error 1
> | FATAL: oe_runmake failed
> NOTE: Task failed:
> /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
> ERROR: TaskFailed event exception, aborting
> ERROR: Build of
> /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb
> do_compile failed
> ERROR: Task 2024
> (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb,
>  do_compile) failed
> 
> The root cause for this behaviour is in wvstreams' configure.ac; the
> weird dbus detection and library path handling breaks successive builds.
> 
> This patch, however, does not fix the configure.ac file but disables
> DBus support for wvstreams at configure time. This at least fixes the
> broken build.
> 
> Signed-off-by: Thilo Fromm <t.fromm at dresearch.de>
> ---
>  recipes/wvstreams/wvstreams_4.6.bb |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/wvstreams/wvstreams_4.6.bb b/recipes/wvstreams/wvstreams_4.6.bb
> index 91abc7d..b298a97 100644
> --- a/recipes/wvstreams/wvstreams_4.6.bb
> +++ b/recipes/wvstreams/wvstreams_4.6.bb
> @@ -1,7 +1,7 @@
>  HOMEPAGE = "http://alumnit.ca/wiki/index.php?page=WvStreams"
>  LICENSE = "LGPL"
>  DESCRIPTION = "WvStreams is a network programming library in C++"
> -DEPENDS = "zlib openssl (>= 0.9.8)"
> +DEPENDS = "zlib openssl (>= 0.9.8) dbus (> 1.2.14)"

Since you remove DBus support, can this dependency be removed? Maybe add
a note to the comment below to not forget to put `dbus` into `DEPENDS`.
 
>  SRC_URI = "http://wvstreams.googlecode.com/files/${PN}-${PV}.tar.gz \
>  	"
> @@ -10,7 +10,8 @@ inherit autotools pkgconfig
>  
>  LDFLAGS_append = " -Wl,-rpath-link,${TOOLCHAIN_PATH}/${TARGET_SYS}/lib"
>  
> -EXTRA_OECONF = " --without-tcl --without-qt --without-pam"
> +# tfm: dbus build currently broken
> +EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-dbus"
>  
>  PACKAGES_prepend = "libuniconf libuniconf-dbg "
>  PACKAGES_prepend = "uniconfd uniconfd-dbg "

I think you also need to increment `PR`.

Can you resend the patch as v2 (`--subject-prefix in `git help
format-patch`) and update the status in the patch queue [2].


Thanks,

Paul


[1] http://wiki.openembedded.net/index.php/Commit_Policy
[2] http://wiki.openembedded.net/index.php/Patchwork
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100928/decb9574/attachment-0002.sig>