[oe] [PATCH 14/18] cdparanoia: create libcdparanoia packages

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Wed Sep 29 20:56:28 UTC 2010


2010/9/29 Andreas Oberritter <obi at opendreambox.org>:
> * Create separate packages for the libraries, which
>  use a different license than the executable:
>
> "The cdparanoia command line tool versions 10.1 and later are
>  distributed under the GNU General Public Licence v2.0 or, at your
>  option, any later version of the GPL."
>
> "The 10.1 and later release versions of the cdda-interface and
>  cdda-paranoia libraries are distributed the GNU Lesser General Public
>  License v2.1 or, at your option, any later version of the GNU LGPL."
>
> Signed-off-by: Andreas Oberritter <obi at opendreambox.org>
> ---
>  recipes/cdparanoia/cdparanoia_10.2.bb |   14 ++++++++++++++
>  recipes/cdparanoia/cdparanoia_svn.bb  |   15 ++++++++++++++-
>  2 files changed, 28 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/cdparanoia/cdparanoia_10.2.bb b/recipes/cdparanoia/cdparanoia_10.2.bb
> index 7bb6035..894c038 100644
> --- a/recipes/cdparanoia/cdparanoia_10.2.bb
> +++ b/recipes/cdparanoia/cdparanoia_10.2.bb
> @@ -2,6 +2,7 @@
>  # Copyright (C) 2005, Advanced Micro Devices, Inc.  All Rights Reserved
>  # Released under the MIT license (see packages/COPYING)
>  LICENSE = "GPL"
> +PR = "r1"
>
>  SRC_URI = "http://downloads.xiph.org/releases/cdparanoia/cdparanoia-III-10.2.src.tgz \
>          file://fixes10.patch \
> @@ -17,6 +18,19 @@ S = "${WORKDIR}/cdparanoia-III-10.2"
>
>  inherit autotools
>
> +PACKAGES += "libcdparanoia libcdparanoia-dev libcdparanoia-static"
> +
> +LICENSE_libcdparanoia = "LGPLv2.1"
> +LICENSE_libcdparanoia-dev = "LGPLv2.1"
> +LICENSE_libcdparanoia-static = "LGPLv2.1"
> +
> +FILES_${PN} = "${bindir}/*"
> +FILES_${PN}-dev = ""
> +FILES_${PN}-static = ""
> +FILES_libcdparanoia = "${libdir}/lib*${SOLIBS}"
> +FILES_libcdparanoia-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV}"
> +FILES_libcdparanoia-static = "${libdir}/*.a"
> +
>  do_install() {
>         oe_runmake BINDIR="${D}/usr/bin" MANDIR="${D}/usr/share/man/" \
>                    INCLUDEDIR="${D}/usr/include/" LIBDIR="${D}/usr/lib" install
> diff --git a/recipes/cdparanoia/cdparanoia_svn.bb b/recipes/cdparanoia/cdparanoia_svn.bb
> index 0f81d6c..5610450 100644
> --- a/recipes/cdparanoia/cdparanoia_svn.bb
> +++ b/recipes/cdparanoia/cdparanoia_svn.bb
> @@ -2,7 +2,7 @@
>  # Copyright (C) 2005, Advanced Micro Devices, Inc.  All Rights Reserved
>  # Released under the MIT license (see packages/COPYING)
>
> -PR = "r2"
> +PR = "r3"
>  LICENSE = "GPL"
>
>  PV = "10.2+svnr${SRCPV}"
> @@ -21,6 +21,19 @@ PARALLEL_MAKE = ""
>
>  inherit autotools
>
> +PACKAGES += "libcdparanoia libcdparanoia-dev libcdparanoia-static"
> +
> +LICENSE_libcdparanoia = "LGPLv2.1"
> +LICENSE_libcdparanoia-dev = "LGPLv2.1"
> +LICENSE_libcdparanoia-static = "LGPLv2.1"
> +
> +FILES_${PN} = "${bindir}/*"
> +FILES_${PN}-dev = ""
> +FILES_${PN}-static = ""
> +FILES_libcdparanoia = "${libdir}/lib*${SOLIBS}"
> +FILES_libcdparanoia-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV}"
> +FILES_libcdparanoia-static = "${libdir}/*.a"
> +
>  do_install() {
>        oe_runmake BINDIR="${D}/usr/bin" MANDIR="${D}/usr/share/man/" \
>                   INCLUDEDIR="${D}/usr/include/" LIBDIR="${D}/usr/lib" install
> --
> 1.7.1
>

I feel there should be an
RDEPENDS_${PN} += "libcdparanioa"
to add the dependency that is now created (if i recall correctly
cdparanoia is statically build).
There is no -doc package?
Other wise this one looks fine to me. Will test tomorrow (time permitting).

Frans




More information about the Openembedded-devel mailing list