[oe] [PATCH] Add falloc.h to the exported kernel header files.

[Paul Menzel]

Dear Thilo,


Am Mittwoch, den 29.09.2010, 17:31 +0200 schrieb Thilo Fromm:

[…]

> >> This adds include/linux/falloc.h to the list of files
> >> exported by the kernel to the C library.
> >> The include file is required for building e.g. a recent util-linux-ng
> >> against 2.6.24.
> >
> > it looks like the same fix was committed upstream [3] in March 2008 [4].
> > Since the Linux kernel 2.6.24 was released in January 2008 this fixed
> > should be present in all Linux kernels>= 2.6.24.
> 
> It is present in all kernels > 2.6.24. It's actually in the changelog 
> for 2.6.25: 
> <http://ftp.halifax.rwth-aachen.de/kernel/linux/kernel/v2.6/ChangeLog-2.6.25> 
> (search the page for "falloc.h").
> 
> But we're stuck with 2.6.24 :-/
> 
> > If you sent a patch iteration, please add that information to the commit
> > message.
> 
> What's a patch iteration?

I am no native speaker, but I mean a revised patch, i. e. PATCH v2.

> >> Signed-off-by: Thilo Fromm<t.fromm at dresearch.de>
> >> ---
> >>   .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
> >>   .../linux-libc-headers_2.6.24.bb                   |    1 +
> >>   2 files changed, 11 insertions(+), 0 deletions(-)
> >>   create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch
> >>
> >> diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
> >> new file mode 100644
> >> index 0000000..5860e88
> >> --- /dev/null
> >> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
> >
> > Could you please add a patch header as suggested in [2].
> 
> I suppose you're referring to a line like
> 
> upstream: OE-only
> 
> ? As this patch is not supposed to go upstream (because it's already 
> there) - do you think this is still necessary?

I looked at your revised patch (v2). This information is not for the
commit message but should be placed at the beginning of the patch file
`files/export_falloc_h.patch` [1]. My suggestion is the following.

        upstream: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e
        comment: Patch is present in Linux kernel >= 2.6.25.

> Otherwise I'd just adjust the patch summary and then resubmit the patch 
> as v2.


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/eglibc/files/eglibc-dont-cache-slibdir.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100930/5a0cb8f5/attachment-0002.sig>