[oe] [PATCH 00/18] Patches from opendreambox.org

[Paul Menzel]

Dear Andreas,


Am Mittwoch, den 29.09.2010, 20:36 +0000 schrieb Andreas Oberritter:

> in order to synchronize our work with upstream, I've prepared some
> patches. More patches will follow. You can cherry-pick or pull them
> from git, if you like:
> 
> git://git.opendreambox.org/git/obi/openembedded.git for-upstream

thank you for your patches. I took a quick glance and as far as I can
judge it they are of very high quality.

I will build test your changes on minimal-{libc,eglibc,uclibc} and
Ȧngström 2008.1 and report back.

> I'm submitting patches to OE for the first time, so please be patient
> if I've missed some guideline or the like.

I have some minor nitpicks and comments.

1. When you add patches please add a short header to the patch files
[1][2]. If you could spend the time to submit patches upstream that
would be great.

I think that applies to the following recipes.

[PATCH 03/18] libmad-0.15.1b: fix compile with gcc-4.4 (mipsel)
http://patchwork.openembedded.org/patch/3110/

[PATCH 04/18] libsigc++-1.2: fix installation
http://patchwork.openembedded.org/patch/3106/

[PATCH 06/18] netkit-base-0.17: fix compile with gcc-4.x
http://patchwork.openembedded.org/patch/3115/

[PATCH 09/18] cdrkit: update from 1.1.9 to 1.1.10
http://patchwork.openembedded.org/patch/3112/

[PATCH 11/18] tremor-20041119: Add pkgconfig file, provide libvorbisidec
http://patchwork.openembedded.org/patch/3103/

[PATCH 17/18] libxmlccwrap-0.0.12: initial recipe
http://patchwork.openembedded.org/patch/3109/

[PATCH 18/18] mjpegtools-1.9.0: initial recipe
http://patchwork.openembedded.org/patch/3108/

2. I do not know if you did this, but for new recipes you can sanitize
them using `oestylize.py` [3].

3. It is not demanded by the commit policy, but if you fix compile or
other errors, I would prefer to see the relevant log of the failed build
in the commit message.

4. You could note in your patches what machines and distributions you
used for building and testing your changes.

5. Please remember to update the patch queue if appropriate [4].

Thanks a lot again for your patches. I am looking forward to more.


Thanks,

Paul


[1] http://wiki.openembedded.net/index.php/Push_patches_upstream
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/eglibc/files/eglibc-dont-cache-slibdir.patch
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/contrib/oe-stylize.py
[4] http://wiki.openembedded.net/index.php/Patchwork
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100930/73ce971f/attachment-0002.sig>