[oe] [PATCH v3] linux-libc-headers_2.6.24: Add falloc.h to kernel exported headers

[Paul Menzel]

Dear Thilo,


Am Donnerstag, den 30.09.2010, 16:09 +0200 schrieb Thilo Fromm:

> >> This adds include/linux/falloc.h to the list of files exported by the kernel to the C library.
> >> The include file is required for building e.g. a recent util-linux-ng against 2.6.24.
> >>
> >> Starting from 2.6.25 a similar patch has been accepted upstream (the mainline
> >> kernel). For 2.6.24, however, falloc.h is not exported although it's present.
> >>
> [...]
> >>   .../linux-libc-headers/files/export_falloc_h.patch |   11 +++++++++++
> >> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
> >> @@ -0,0 +1,11 @@
> >> +upstream: OE-only
> >
> > Hmm, do you think it is OE only. As written in my other message I
> > consider this an upstream patch, which has been committed already.
> >
> >          upstream: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e
> >          comment: Patch is present in Linux kernel>= 2.6.25.
> 
> Technically, this upstreamed patch is not my patch. Upstream is way 
> older, it's from a different author, etc. Plus it's included in 
> successive kernel releases, but it's not in the version affected by my 
> patch. From my point of view my patch is an OE-only hack because it 
> back-ports to an older kernel version a different patch which originated 
> from OE (?) a long time ago and then went mainline.
> 
> I'll of course change this to your suggestion if this is a problem. I 
> did not do this yet so my patch won't get confused with the original one 
> that went mainline.

But as far as I can see, both patches do exactly the same thing. I do
not care about the authorship.

My main point is, that if someone is going through the patch files and
wonders, if that patch has to go upstream these comments help a lot.

I am not so long into OE, so others might clarify this.

The following would work too.

	upstream: OE-only
	comment: Same patch is present in Linux kernel ≥ 2.6.25 and was committed in <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e>.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100930/237db57b/attachment-0002.sig>