[oe] [PATCH [1/2]] eio: New recipe for eio

[Martin Jansa]

On Fri, Apr 01, 2011 at 12:00:35PM +0200, Paul Menzel wrote:
> Dear Philippe,
> 
> 
> Am Freitag, den 01.04.2011, 10:25 +0300 schrieb Philippe De Swert:
> 
> > Thanks for the review.
> 
> No problem.
> 
> > On 31 March 2011 23:23, Paul Menzel <paulepanter at users.sourceforge.net> wrote:
> > > Am Donnerstag, den 31.03.2011, 22:39 +0300 schrieb Philippe De Swert:
> > >
> > > »eio: add initial recipe (svn)«  or something like that would be a
> > > better commit summary in my opinion.
> > 
> > I'll keep that in mind
> 
> Additionally »[PATCH [1/2]]« seems to confuse `git am` to use
> 
> 	] eio: New recipe for eio
> 
> as the commit summary. So only no nested brackets please.
> 
> I found one other problem. The license is LGPL 2.1+ and not MIT or BSD
> [1].
> 
> > >> +
> > >> +# Some upgrade path tweaking
> > >> +AUTO_LIBNAME_PKGS = ""
> > >
> > > What upgrade patch?
> > 
> > Yeah I should have double checked that... Just put it there as all the
> > other enlightenment .inc files had it.
> 
> Maybe Martin can comment on that.

Don't know if eio will part in next efl release (1.1.0 probably), but
libeio-ver-pre-svn-09 is not nice package name anyways, so I vote to
keep it for future upgrade path :).

> 
> > >> diff --git a/recipes/efl1/eio_svn.bb b/recipes/efl1/eio_svn.bb
> > >> new file mode 100644
> > >> index 0000000..6a12dcf
> > >> --- /dev/null
> > >> +++ b/recipes/efl1/eio_svn.bb
> > >> @@ -0,0 +1,13 @@
> > >> +require eio.inc
> > >> +
> > >> +SRCREV = "${EFL_SRCREV}"
> > >> +PV = "0.1.0+svnr${SRCPV}"
> > >> +PR = "${INC_PR}.0"
> > >> +DEFAULT_PREFERENCE = "-1"
> > >
> > > It is the only recipe, so `DP = "-1"` should not be useful.
> > 
> > Just wanted to be future proof for when the actual versioned recipes come.

Also fine with DP = "-1" (even on only one version in this case) 
in case there will be eio_1.1.0.bb

> I think it should be adapted if there is a recipe for a released
> version.
> 
> Please resend the patch as [PATCH 1/2 v2] after Martin has commented.

For me, just fix LICENSE and I'm fine with it (just overlooked license
in off-list review).

Cheers,
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110404/c91d16ee/attachment-0002.sig>