[oe] [PATCHv2] kernel/module-base: Append PR to MACHINE_KERNEL_PR

[Frans Meulenbroeks]

2011/4/5 Koen Kooi <koen at dominion.thruhere.net>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05-04-11 11:32, Phil Blundell wrote:
>> On Tue, 2011-04-05 at 11:23 +0200, Koen Kooi wrote:
>>> On 05-04-11 11:08, Andreas Oberritter wrote:
>>>> Thereby making MACHINE_KERNEL_PR mandatory for all machines?
>>>
>>> I don't see why not.
>>
>> The majority of machines aren't using it at present so this would be an
>> unexpected (and presumably unwelcome) change for them.  That seems like
>> a bad idea unless there is a compelling reason why it needs to be done.
>
> First: You don't get to complain about broken kernel module PRs when you
> are against rebuilding them when the kernel changes.
>
> Second: the majority of machines doesn't even build, so those kind of
> arguments are bogus

In the tree I have handy there are 313 machines.
I'd be rather hesitant to make statements that the majority does not
build without having that tested (and if you have: how many do not
build).

These are the files that have M_K_PR in them:
ea3250.conf:MACHINE_KERNEL_PR		= "r0"
nokia900.conf:MACHINE_KERNEL_PR = "r58"
omap3-pandora.conf:MACHINE_KERNEL_PR = "r2"
smartq5.conf:MACHINE_KERNEL_PR = "r1"
smartqv7.conf:MACHINE_KERNEL_PR = "r0"
include/davinci.inc:MACHINE_KERNEL_PR = "r50"
include/kirkwood.inc:MACHINE_KERNEL_PR = "r19"
include/omap3.inc:MACHINE_KERNEL_PR = "r101"
include/omap4.inc:MACHINE_KERNEL_PR = "r101"
include/palmpre.inc:MACHINE_KERNEL_PR = "r93"
include/ti814x.inc:MACHINE_KERNEL_PR = "r1"
include/ti816x.inc:MACHINE_KERNEL_PR = "r1"

Actually it seems quite some machines used to test the 2011.3 release
do not seem to use M_K_PR
(http://wiki.openembedded.org/index.php/Release-2011.03).

Frans.

PS: the machines I feel responsible for, and use regularly all build.
Not all of them do use M_K_PR.

>
> So apart from handwaving ("presumably unwelcome") do you have any actual
> arguments against moving all machines to MACHINE_KERNEL_PR?
>
> -----BEGIN PGP SI-
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFNmvFnMkyGM64RGpERAqqkAJ4vgIlyQ3cgVAnZS2rcjdGJHjn3uQCfTOjt
> UtUZ9dRa9XfWvnganZPrAbg=
> =KtE5
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>