[oe] [PATCH v2] firefox: Added libIDL-2.0 CFLAGS and LIBS

[Patrik Dahlström (student)]

lördag 16 april 2011 15.28.39 skrev  Paul Menzel:
> Dear Patrik,
> 
> Am Freitag, den 15.04.2011, 18:42 +0200 schrieb Patrik Dahlström:
> > * autoconf does not fill in any CFLAGS or LIBS for libIDL-2.0. This
> > 
> >   patch sets the appropriate flags in autoconf.mk.in for
> >   HOST_LIBIDL_CFLAGS and HOST_LIBIDL_LIBS.
> > 
> > Signed-off-by: Patrik Dahlström <patda293 at student.liu.se>
> > ---
> > 
> >  recipes/mozilla/firefox_3.6.8.bb |    7 +++++--
> >  1 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/recipes/mozilla/firefox_3.6.8.bb
> > b/recipes/mozilla/firefox_3.6.8.bb index 04dde08..828822c 100644
> > --- a/recipes/mozilla/firefox_3.6.8.bb
> > +++ b/recipes/mozilla/firefox_3.6.8.bb
> > @@ -28,6 +28,7 @@ SRC_URI[archive.md5sum] =
> > "0ee5f14fd8be07513d16131027ebcb61"
> > 
> >  SRC_URI[archive.sha256sum] =
> >  "fc609cc6a0ddaa2a9ebd8511ec39ae4a404e1107a12e07b233e2afca51d9a10e"
> >  
> >  S = "${WORKDIR}/mozilla-1.9.2"
> > 
> > +export PKG_CONFIG=${STAGING_BINDIR_NATIVE}/pkg-config
> 
> is that line really needed?
It seems I misspelled something here. It was supposed to say PKG_CONFIG_PATH. 
Apparently it works anyway, but I don't know if it would work for every kind 
of configuration.
However, when I used $PKG_CONFIG instead of $(pkg-config ...) below it didn't 
work. I will try to reproduce the error when I have some time over and be more 
precise on what the actual error was (missing glib.h as I recall).
> 
> >  inherit mozilla
> >  require firefox.inc
> > 
> > @@ -37,7 +38,9 @@ EXTRA_OECONF += " --enable-official-branding
> > --disable-crashreporter"
> > 
> >  FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer
> >  -frename-registers -O2"
> >  
> >  do_compile_prepend() {
> > 
> > -	cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
> > -	sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|"
> > security/coreconf/Linux.mk +    cp ${WORKDIR}/jsautocfg.h ${S}/js/src/
> > +    sed -i "s|CPU_ARCH =|CPU_ARCH = ${TARGET_ARCH}|"
> > security/coreconf/Linux.mk +    sed -i "s|HOST_LIBIDL_CFLAGS =
> > \@HOST_LIBIDL_CFLAGS\@|HOST_LIBIDL_CFLAGS = $(pkg-config --cflags
> > libIDL-2.0)|" config/autoconf.mk.in +    sed -i "s|HOST_LIBIDL_LIBS   =
> > @HOST_LIBIDL_LIBS@|HOST_LIBIDL_LIBS = $(pkg-config --libs libIDL-2.0)|"
> > config/autoconf.mk.in
> > 
> >  }
> 
> Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>
> 
> Is that bug fixed in newer releases of Firefox?
This was the latest release of firefox in OE. I didn't try to create a new 
recipe for any newer version of FF.
> 
> 
> Thanks,
My pleasure.
> 
> Paul
-- 
MvH / with best regards
Patrik Dahlström