[oe] [oe-meta][PATCHv2] 1/3] libnet: Clean and upgrade (see below)

[Paul Menzel]

Dear Michael,


thank you for your patches.

Am Mittwoch, den 20.04.2011, 10:57 +0200 schrieb Michael Lippautz:
> * libbnet upstream on packetfactor is dead
>   using https://github.com/sam-github/libnet instead
> * Move to version 1.1.5
> * Dropped patches (not needed): support-uclibc, new-autotools
> * Added LIC_FILES_CHKSUM
> * Removed useless do_install_append, works automatically
> * Not building statically anymore
> * Should be compatible with old v1.1 versions
> 
> Signed-off-by: Michael Lippautz <michael.lippautz at gmail.com>
> ---
>  .../libnet/libnet-1.1.5/fix-endianess-test.patch   |   38 ++++++++++++++++++++
>  .../recipes-connectivity/libnet/libnet_1.1.5.bb    |   24 ++++++++++++
>  2 files changed, 62 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-connectivity/libnet/libnet-1.1.5/fix-endianess-test.patch
>  create mode 100644 meta-oe/recipes-connectivity/libnet/libnet_1.1.5.bb

[…]

> diff --git a/meta-oe/recipes-connectivity/libnet/libnet_1.1.5.bb b/meta-oe/recipes-connectivity/libnet/libnet_1.1.5.bb
> new file mode 100644
> index 0000000..ec426a5
> --- /dev/null
> +++ b/meta-oe/recipes-connectivity/libnet/libnet_1.1.5.bb
> @@ -0,0 +1,24 @@
> +DESCRIPTION = "A packet dissection and creation library"
> +# libnet at packetfactory.net is dead
> +HOMEPAGE = "https://github.com/sam-github/libnet"
> +SECTION = "libs"
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://README;md5=533bea47338d490e86744c6a0c5692e7"

What does the README have to do with the license? I thought if there is
not file `COPYING` – maybe one should be sent upstream – one takes the
header of the source files as for example `libnet_asn1.c` [1].

> +DEPENDS = "libpcap"
> +# There are major API changes beween libnet v1.0 and libnet v1.1
> +PROVIDES = "libnet-1.1"
> +PR = "r0"
> +
> +SRC_URI = "${SOURCEFORGE_MIRROR}/libnet-dev/${PN}-${PV}.tar.gz \
> +           file://fix-endianess-test.patch"
> +
> +SRC_URI[md5sum] = "a9bc1d75a610efcfee200d3e28d8eb8f"
> +SRC_URI[sha256sum] = "75588f8d1232e1df34eccf2dba5e66be197b345a07fae80d8275db994496a20d"
> +
> +S = "${WORKDIR}/${PN}-${PV}"

This is the default [2] and should be dropped.

> +
> +inherit autotools binconfig
> +
> +do_configure_prepend() {
> +        rm -f aclocal.m4 Makefile.am ltmain.sh
> +}


Thanks,

Paul


[1] https://github.com/sam-github/libnet/blob/master/libnet/src/libnet_asn1.c
[2] http://docs.openembedded.org/usermanual/usermanual.html#id327409
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110420/03fe3d7f/attachment-0002.sig>