[oe] [PATCH 2/5] pkgconfig.bbclass: search configs in D instead of S

Stanislav Brabec utx at penguin.cz
Wed Apr 20 15:47:55 UTC 2011


Andreas Oberritter wrote:

> > diff --git a/classes/pkgconfig.bbclass b/classes/pkgconfig.bbclass
> > index d96b708..00298ca 100644
> > --- a/classes/pkgconfig.bbclass
> > +++ b/classes/pkgconfig.bbclass
> > @@ -14,7 +14,7 @@ SYSROOT_PREPROCESS_FUNCS += "pkgconfig_sysroot_preprocess"
> >  
> >  pkgconfig_sysroot_preprocess () {
> >  	install -d ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}
> > -	for pc in `find ${S} -name '*.pc' -type f | grep -v -- '-uninstalled.pc$'`; do
> > +	for pc in `find ${D} -name '*.pc' -type f`; do
> >  		pcname=`basename $pc`
> >  		if [ ! -f ${SYSROOT_DESTDIR}${PKG_CONFIG_DIR}/$pcname ]; then
> >  			oenote "$pcname was not installed."
> > 
> 
> This function just prints a warning, if it finds a .pc file that didn't
> get installed. Using ${D} at this point makes this function a no-op.
> 
> It might be better to just remove it completely.

Good hint. So I'll not submit this patch. Your commit c2c8fe4 already
did the right fix here.

-- 
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus





More information about the Openembedded-devel mailing list