[oe] [beagleboard] [PATCH] gst-plugins-good: v4l2src: Make Leapoard Imaging VGA Camera work out of the box

[Joel A Fernandes]

Hi Vladimir,

On Mon, Aug 1, 2011 at 2:57 AM, Vladimir Pantelic <vladoman at gmail.com> wrote:
> Joel A Fernandes wrote:
>
>>>>  +From d5a1f365bfd4420912735709bcb8004d3ad7226c Mon Sep 17 00:00:00 2001
>>>>  +From: Joel A Fernandes<agnel.joel at gmail.com>
>>>>  +Date: Fri, 29 Jul 2011 17:23:43 -0500
>>>>  +Subject: [PATCH] v4l2src: Add UYVY color format to the list of
>>>> enumerations
>>>>  +
>>>>  +OMAP3 ISP returns -EINVAL for VIDIOC_ENUM_FMT ioctl on video node. Due
>>>> to this, format negotiation fails. This adds UYVY format to the list of
>>>> enumerations.
>>>
>>>  I must be missing something, but what has negotation failure to do with
>>> adding a new format? I would expect adding new formats not to have any
>>> effect if negotiation fails.
>>
>> The way it works is:
>>
>> Enumerate formats ->  Negotiate formats between source and sink pads
>> and set the format
>>
>> Enumerate formats doesn't return UYVY (The driver is supposed to
>> return this but ENUM_FMT ioctl is not implemented in ISP like I was
>> saying). Due to this, the negotiate function is either unable to find
>> a matching format on the sink pad (if you used a UYVY caps filter
>> element) or fails to set the format if you used a more general
>> element.
>
> and why not make ENUM_FMT ioctl return what is needed??? Instead
> of "hacking" the gst driver?
>
>

That'll be a hack as well:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg29718.html

Regards,
Joel