[oe] [PATCH v2] mplayer_git: Fix linker error on x86 machines

[Paul Menzel]

Dear Josua,


thank you for sending a patch iteration with my comments addressed. Just
a side note, you can use `git commit --amend` to edit the commit message
of the last commit. I do not know if you used that since the date looks
different from your initial patch.

Am Dienstag, den 02.08.2011, 21:05 +0200 schrieb Josua Mayer:
> * fix undefined references  in loader/module.o:
>   module.c:(.text+0xd60): undefined reference to `report_entry'
>   module.c:(.text+0xd6a): undefined reference to `report_ret'
>   module.c:(.text+0xd74): undefined reference to `wrapper_target'
>   module.c:(.text+0xd7a): undefined reference to `wrapper'
>   and more of these
> * Apply already existing patch fix-emu_qtx_api.diff
>   This patch was already used in mplayer_svn but is needed
>   for the git version too.
> 
> Signed-off-by: Josua Mayer <josua.mayer97 at googlemail.com>
> ---
>  recipes/mplayer/mplayer_git.bb |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/mplayer/mplayer_git.bb b/recipes/mplayer/mplayer_git.bb
> index 259ce99..995884b 100644
> --- a/recipes/mplayer/mplayer_git.bb
> +++ b/recipes/mplayer/mplayer_git.bb
> @@ -8,7 +8,8 @@ DEPENDS = "libvpx live555 libdvdread libtheora virtual/libsdl ffmpeg xsp zlib li
>  RDEPENDS_${PN} = "mplayer-common"
>  LICENSE = "GPL"
>  SRC_URI = "git://repo.or.cz/mplayer/glamo.git;protocol=git;branch=mplayer2 \
> -   "
> +           file://fix-emu_qtx_api.diff \
> +          "
>  
>  SRC_URI_append_armv7a = " \
>  	   file://0001-video-out-for-omapfb-support.patch \

Long story short I should have looked right away at the commit log for
the patch file [1]. Reading that it would have been clear that this is
needed for x86 targets which the ION seems to be. I thought SHR is
primarily used for ARM mobile devices [2].

Therefore I always want to have the build configuration output from
BitBake pasted in messages and commit messages.

It would be great if you could bring that patch upstream somehow.

I committed your patch with an improved commit message and a `PR` bump
(I hope done correctly) in 1a91fc4b [3].

Unfortunately I could not test this because using `DISTRO = "shr"` and
`MACHINE = "ion"` fails with the following error message.

        Error, Your PACKAGE_ARCHS field contains duplicates. Perhaps you set PACKAGE_EXTRA_ARCHS twice accidently through some tune file?

So please remember to be as elaborate as possible and to provide all
files for others to reproduce your problem. I know looking at the
archive and commit log not everyone follows this rule but it would have
saved me quite some time.


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=ff57f14c99a6ff61ffb7f1c533523e3e934f96e5
[2] http://shr-project.org/trac
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=1a91fc4b705b0c4f45eb088a2f7aea01ebc9c98e
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110803/8c2b977a/attachment-0002.sig>