[oe] [PATCH 2/2] enjoy: make it work with shr-core

[Paul Menzel]

Dear Pau,


thank you for your patches.

Am Mittwoch, den 17.08.2011, 06:51 +0200 schrieb Pau Espin Pedrol:
> * added LIC_FILES_CHKSUM

Please always use present tense in commit messages.

> * added virtual/gettext as it seems it is needed now (it didn't build fine without it)

What is the exact error? It built fine in oe.dev as far as I remember.
Additionally should `inherit gettext` be used?

> * RDEPENDS: added new gstreamer module gst-plugins-good-autodetect needed for enjoy to be able to play files
> * RDEPENDS: updated all other module names because they changed in shr-core

Please always send one patch for one change, which makes it easier to
review. It would be great if you could resend your patch as three
patches (license, build fix and if feasible each RDEPENDS).

> Signed-off-by: Pau Espin Pedrol <pespin.shar at gmail.com>
> ---
>  meta-efl/recipes-efl/e17/enjoy_svn.bb |   13 ++++++++-----
>  1 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/meta-efl/recipes-efl/e17/enjoy_svn.bb b/meta-efl/recipes-efl/e17/enjoy_svn.bb
> index eab81b4..c6394c7 100644
> --- a/meta-efl/recipes-efl/e17/enjoy_svn.bb
> +++ b/meta-efl/recipes-efl/e17/enjoy_svn.bb
> @@ -5,7 +5,10 @@ SRCREV = "${EFL_SRCREV}"
>  PV = "0.0+svnr${SRCPV}"
>  PR = "r4"
>  
> -DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=0f507c68d42d1cc0fcb507d007112bf2"

Please look at the style guide where to add such fields. In this case it
is not listed directly but it should go right below `LICENSE`.

> +
> +
> +DEPENDS += "virtual/gettext gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}"
>  
>  #1st needed for all formats
>  #2nd needed for mp3 playback
> @@ -13,10 +16,10 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
>  #4th needed for flac playback
>  #5th needed binary to create db
>  RDEPENDS += "\
> -	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  \
> -	${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \
> -	gst-plugin-ogg gst-plugin-ivorbisdec \
> -	gst-plugin-flac \
> +	gst-plugins-base-typefindfunctions gst-plugins-base-playbin gst-plugins-base-volume gst-plugins-base-decodebin2 gst-plugins-good-autodetect \
> +	${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly-mad gst-plugins-good-id3demux', d)} \
> +	gst-plugins-base-ogg gst-plugins-base-ivorbisdec \
> +	gst-plugins-good-flac \
>  	lightmediascanner-test \
>  	"


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Styleguide
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110817/e6e5d3c4/attachment-0002.sig>