[oe] [meta-oe][PATCH 1/3] kexec-tools-klibc: import from meta-zaurus layer

Paul Menzel paulepanter at users.sourceforge.net
Thu Aug 18 08:40:46 UTC 2011


Dear Martin,


Am Donnerstag, den 18.08.2011, 10:14 +0200 schrieb Martin Jansa:
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>

please include the commit id as documented in the Commit Patch Message
Guidelines [1].

Why was is not included into meta-oe in the first place? Should it be
included in oe-core right away?

> ---
>  .../kexec/kexec-tools-klibc-2.0.2/elf.patch        |   94 +++++++++++++++++++
>  .../kexec/kexec-tools-klibc-2.0.2/errno.patch      |   13 +++
>  .../kexec/kexec-tools-klibc-2.0.2/other.patch      |   97 ++++++++++++++++++++
>  .../kexec/kexec-tools-klibc-2.0.2/string.patch     |   11 ++
>  .../kexec/kexec-tools-klibc-2.0.2/syscall.patch    |   46 +++++++++
>  .../kexec/kexec-tools-klibc_2.0.2.bb               |   27 ++++++
>  6 files changed, 288 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-kernel/kexec/kexec-tools-klibc-2.0.2/elf.patch
>  create mode 100644 meta-oe/recipes-kernel/kexec/kexec-tools-klibc-2.0.2/errno.patch
>  create mode 100644 meta-oe/recipes-kernel/kexec/kexec-tools-klibc-2.0.2/other.patch
>  create mode 100644 meta-oe/recipes-kernel/kexec/kexec-tools-klibc-2.0.2/string.patch
>  create mode 100644 meta-oe/recipes-kernel/kexec/kexec-tools-klibc-2.0.2/syscall.patch
>  create mode 100644 meta-oe/recipes-kernel/kexec/kexec-tools-klibc_2.0.2.bb

[…]

> diff --git a/meta-oe/recipes-kernel/kexec/kexec-tools-klibc_2.0.2.bb b/meta-oe/recipes-kernel/kexec/kexec-tools-klibc_2.0.2.bb
> new file mode 100644
> index 0000000..e4f126e
> --- /dev/null
> +++ b/meta-oe/recipes-kernel/kexec/kexec-tools-klibc_2.0.2.bb
> @@ -0,0 +1,27 @@
> +# the binaries are statically linked against klibc
> +require recipes-kernel/kexec/kexec-tools.inc
> +SRC_URI[md5sum] = "bc401cf3262b25ff7c9a51fc76c8ab91"
> +SRC_URI[sha256sum] = "549ab65c18a2229b6bf21b6875ca6bbe0e579bca08c3543ce6aaf8287a0b4188"
> +
> +PR = "r6"

Start with "r0" or will that cause problems for the meta-zaurus users?

> +inherit klibc
> +
> +FILESPATH =. "${FILE_DIRNAME}/kexec-tools-${PV}:"
> +
> +SRC_URI += "file://elf.patch \
> +            file://errno.patch \
> +            file://string.patch \
> +            file://syscall.patch \
> +            file://other.patch \
> +            "
> +
> +S = "${WORKDIR}/kexec-tools-${PV}"
> +
> +EXTRA_OECONF = " --without-zlib"

Is `+=` needed? Either way the space could be removed in a fix up patch.

> +
> +PACKAGES =+ "kexec-klibc kdump-klibc"
> +
> +CFLAGS += "-I${STAGING_DIR_HOST}${base_libdir}/klibc/include -I${STAGING_DIR_HOST}${base_libdir}/klibc/include/bits32"
> +
> +FILES_kexec-klibc = "${sbindir}/kexec"
> +FILES_kdump-klibc = "${sbindir}/kdump"

Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Importing_from_Elsewhere
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110818/73de8ea8/attachment-0002.sig>


More information about the Openembedded-devel mailing list