[oe] [PATCH] Add a new recipe: libroxml

Thu Aug 18 16:40:26 UTC 2011

Dear Tristan,

thank you for your patch. There are some style problems and I hit some
build issues, I will all mentioning inline.

First of all I just noticed during this reply that you also attached
this patch. That is the right thing to do since Google Mail auto wraps
lines and therefore patches get broken. I recommend you to use `git
send-email` or a mail program though.

Am Donnerstag, den 18.08.2011, 17:48 +0200 schrieb Tristan Lelong:

> Add a new recipe: libroxml

Please follow the commit policy [1][2][3] on how to format the commit
summary and message.

	libroxml: Add version 2.1.0

Also in your pasted message you copied the header twice.

> libroxml is a small fast and powerfull xml parsing library.

s/powerfull/powerful/

> It handles parsing, creating, modifying xml documents

Full stop at the end.

Please add the build configuration you used for building and run
testing.

> Signed-off-by: Tristan Lelong <tristan.lelong at libroxml.net>
> ---
>  recipes/libroxml/libroxml.inc      |   23 +++++++++++++++++++++++
>  recipes/libroxml/libroxml_2.1.0.bb |    8 ++++++++
>  2 files changed, 31 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/libroxml/libroxml.inc
>  create mode 100644 recipes/libroxml/libroxml_2.1.0.bb
> 
> diff --git a/recipes/libroxml/libroxml.inc b/recipes/libroxml/libroxml.inc
> new file mode 100644
> index 0000000..5ade6e7
> --- /dev/null
> +++ b/recipes/libroxml/libroxml.inc
> @@ -0,0 +1,23 @@
> +

Please no empty line at the beginning.

> +DESCRIPTION = "small, fast and powerfull xml library"

Typo as above. Please start with a capital letter.

> +LICENSE = "LGPL"
> +SECTION = "libs"
> +PRIORITY = "optional"
> +MAINTAINER = "Tristan Lelong <tristan.lelong at libroxml.net>"

There is no maintainer field. Use `AUTHOR` instead.

> +HOMEPAGE = "http://www.libroxml.net"

Please order these fields according to the style guide [4].

> +
> +PROVIDES = "libroxml"
> +RPROVIDES = "libroxml"

Not needed as far as I know.

> +
> +SRC_URI = "http://libroxml.googlecode.com/files/libroxml-2.1.0.tar.gz"
> +
> +S = ${WORKDIR}/${PN}-${PV}

That is the default and can be left out.

I see a pc (pkgconfig) file is shipped. `inherit pkgconfig` should be
added then I think.

> +
> +do_install() {
> +        oe_runmake install DESTDIR=${D}
> +}
> +
> +PACKAGES = ${PN}

Also not needed.

> +
> +FILES_${PN} = ${libdir}/libroxml.so.0 ${bindir}/roxml

Should `roxml` be installed with the library?

> +

No empty line at the end please.

> diff --git a/recipes/libroxml/libroxml_2.1.0.bb
> b/recipes/libroxml/libroxml_2.1.0.bb
> new file mode 100644
> index 0000000..22fff51
> --- /dev/null
> +++ b/recipes/libroxml/libroxml_2.1.0.bb
> @@ -0,0 +1,8 @@
> +
> +PR = "r0"

Please use `INC_PR` (also adapt the `*.inc`) and move it below the
require line.

> +
> +require libroxml.inc
> +
> +SRC_URI[md5sum] = "eb69737ba6dc345399531dfa5975a53d"
> +SRC_URI[sha256sum] = "823d9d495bc07618355e3137e289dfcc792b8a513f12452a2aba9c88b48f2e2d"
> +

No empty line at the end please. `git diff --check` should warn you
about this.

I tried to build your recipe with my modifications above using
`angstrom-2010.x` for `MACHINE = "beagleboard". It fails with the
following error.

        NOTE: package libroxml-2.1.0-r0: task do_qa_staging: Started
        arm-angstrom-linux-gnueabi-objcopy: Unable to recognise the format of the input file `/oe/build-angstrom-next/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/libroxml-2.1.0-r0/package/usr/bin/roxml'
        arm-angstrom-linux-gnueabi-strip: Unable to recognise the format of the input file `/oe/build-angstrom-next/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/libroxml-2.1.0-r0/package/usr/bin/roxml'
        arm-angstrom-linux-gnueabi-objcopy: Unable to recognise the format of the input file `/oe/build-angstrom-next/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/libroxml-2.1.0-r0/package/usr/bin/roxml'
        ERROR: runstrip: ''arm-angstrom-linux-gnueabi-strip' --remove-section=.comment --remove-section=.note '/oe/build-angstrom-next/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/libroxml-2.1.0-r0/package/usr/bin/roxml'' strip command failed
        NOTE: package libroxml-2.1.0-r0: task do_qa_staging: Succeeded
        ERROR: QA Issue with libroxml: Architecture did not match (40 to 3) on /work/armv7a-angstrom-linux-gnueabi/libroxml-2.1.0-r0/packages-split/libroxml/usr/lib/libroxml.so.0
        ERROR: QA Issue with libroxml: Architecture did not match (40 to 3) on /work/armv7a-angstrom-linux-gnueabi/libroxml-2.1.0-r0/packages-split/libroxml/usr/bin/roxml
        ERROR: QA run found fatal errors. Please consider fixing them.
        NOTE: package libroxml-2.1.0-r0: task do_package_qa: Failed
        ERROR: Function 'do_package_qa' failed

`minimal` and `minimal-uclibc` fail too.

        NOTE: package libroxml-2.1.0-r0: task do_populate_sysroot: Succeeded
        ERROR: runstrip: ''arm-oe-linux-gnueabi-strip' --remove-section=.comment --remove-section=.note '/oe/build-minimal-eglibc/minimal-dev/work/armv7a-oe-linux-gnueabi/libroxml-2.1.0-r0/package/usr/bin/roxml'' strip command failed
        NOTE: Running task 770 of 777 (ID: 4, /oe/openembedded/recipes/libroxml/libroxml_2.1.0.bb, do_qa_staging)
        NOTE: package libroxml-2.1.0-r0: task do_qa_staging: Started
        NOTE: package libroxml-2.1.0-r0: task do_qa_staging: Succeeded
        ERROR: QA Issue with libroxml: Architecture did not match (40 to 3) on /work/armv7a-oe-linux-gnueabi/libroxml-2.1.0-r0/packages-split/libroxml/usr/lib/libroxml.so.0
        ERROR: QA Issue with libroxml: Architecture did not match (40 to 3) on /work/armv7a-oe-linux-gnueabi/libroxml-2.1.0-r0/packages-split/libroxml/usr/bin/roxml
        ERROR: QA run found fatal errors. Please consider fixing them.
        NOTE: package libroxml-2.1.0-r0: task do_package_qa: Failed
        ERROR: Function 'do_package_qa' failed

Are you sure `Makefile` can deal with cross compilation?

Thanks,

Paul

[1] http://wiki.openembedded.org/index.php/Commit_Policy
[2] http://wiki.openembedded.org/index.php/Commit_log_example
[3] http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines
[4] http://wiki.openembedded.org/index.php/Styleguide
[5] http://wiki.openembedded.org/index.php/Styleguide#PR_variables_with_recipes_that_use_INC_files
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110818/3a280fdf/attachment-0002.sig>