[oe] [PATCH][meta-oe] python-lxml: Added new recipe in meta-oe for 2.2.8 version

[Ahsan, Noor]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org
> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
> Paul Menzel
> Sent: Monday, August 29, 2011 3:26 PM
> To: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [PATCH][meta-oe] python-lxml: Added new recipe in
> meta-oe for 2.2.8 version
> 
> Dear Noor,
> 
> 
> Am Donnerstag, den 18.08.2011, 16:09 +0500 schrieb Noor, Ahsan:
> > From: Noor Ahsan <noor_ahsan at mentor.com>
> >
> > * Added new recipe in meta-oe for 2.2.8 version
> 
> I am sorry your patch has not gotten any review and has not been pushed
> to meta-oe. It would be nice though, if you could take general comments
> to your other patches and apply those to for example this patch.
> 
> 1. Please update the commit summary.
> 2. Please remove the redundant line from the commit message’s body.
> 3. Please note that you got the recipe from oe.dev. I guess you did,
> did not you?
> (4. Include what build and run time environment you used for testing.)
> 5. Now that you have got the set up to send pull requests you can then
> send that a version v2 with a pull request.
> 
> > Signed-off-by: Noor Ahsan <noor_ahsan at mentor.com>
> 
> With my comments addressed you can add
> 
> 	Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
> 
> to the commit message.
> 
> I am sorry that you have to resend it, but reviewing and writing
> comments also takes a lot of time, people tend to not have a lot of.
> Luckily Git (`git commit --amend` or `git rebase -i …`) makes it easy
> for you to improve patches, so it only should take a few minutes.
> 
> 
> Thanks,
> 
> Paul

HI,

Thanks. I will send it with my next bunch of recipes.

Regards,
Noor