[oe] [meta-oe][PATCH 1/3] bonnie++: Add version 1.03c (initial recipe)

[Ahsan, Noor]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org
> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf
Of
> Koen Kooi
> Sent: Tuesday, August 30, 2011 4:49 PM
> To: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH 1/3] bonnie++: Add version 1.03c
> (initial recipe)
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Op 30-08-11 12:58, Noor, Ahsan schreef:
> > From: Noor Ahsan <noor_ahsan at mentor.com>
> >
> > * Imported from oe.dev commit id
> 44985d56bc556786812a0a02d6219afd31a7381d. * Merge .bb and .inc file.
> >
> > Signed-off-by: Noor Ahsan <noor_ahsan at mentor.com> --- meta-
> oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb |   30
> ++++++++++++++++++++ .../bonnie/files/gcc-4.3-fixes.patch
> |   19 ++++++++++++ 2 files changed, 49 insertions(+), 0 deletions(-)
> create mode 100644
> > meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb create mode
100644
> meta-oe/recipes-benchmark/bonnie/files/gcc-4.3-fixes.patch
> >
> > diff --git a/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb
> b/meta-oe/recipes-benchmark/bonnie/bonnie++_1.03c.bb new file mode
> 100644 index 0000000..2067307 --- /dev/null +++ b/meta-oe/recipes-
> benchmark/bonnie/bonnie++_1.03c.bb @@ -0,0 +1,30 @@ +DESCRIPTION =
> "Tests large file IO and
> > creation/deletion of small files." +HOMEPAGE =
> "http://www.coker.com.au/bonnie++/" +LICENSE = "GPL v2"
> 
> without spaces please
> 
> > +LIC_FILES_CHKSUM =
> "file://copyright.txt;md5=cd4dde95a6b9d122f0a9150ae9cc3ee0" + +SRC_URI
> = "http://www.coker.com.au/bonnie++/bonnie++-${PV}.tgz \ +
> file://gcc-4.3-fixes.patch \ +           " +SRC_URI[md5sum] =
> "77a1ba78f37bdd7f024b67e1e36ad151" +SRC_URI[sha256sum] =
> > "c674f1182f4c20f1e6d038feceb0a6617fc3e7658dfbbac89396043b49612a26" +
> +SCRIPTS = "bon_csv2html bon_csv2txt" +EXES = "bonnie++ zcav"
> 
> And move those 2 below the inherit line please.
> 
> > + +inherit autotools + +do_install () { +        install -d ${D}/bin
> +        install -d ${D}/sbin +        install -m 0755 ${EXES}
> ${D}/sbin +        install -m 0755 ${SCRIPTS} ${D}/bin +} + +PACKAGES
> += "bonnie-scripts" + +FILES_${PN} = "/sbin" +FILES_bonnie-
> scripts="/bin" + +TARGET_CC_ARCH
> > += "${LDFLAGS}"
> 
> and move this one above do_install please. The general idea is to
group
> them by usage and TARGET_CC_ARCH is a configure/compile thing.
> 
> 
> regards,
> 
> Koen


Hi,

The recipe is verified on oe-styliz.py script and the formatting is done
by that script. Your recommendations are conflicting with oe-stylize.
Kindly update oe-stylize according to your recommendation so that it
give output according to your expectations.

Thanks.

Regards,
Noor