[oe] [meta-oe][PATCH 1/1] xserver-nodm-init: move systemd service to xserver-nodm-init-systemd

Otavio Salvador otavio at ossystems.com.br
Fri Dec 30 12:34:02 UTC 2011


On Fri, Dec 30, 2011 at 10:09, Koen Kooi <koen at dominion.thruhere.net> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 28-12-11 18:05, Otavio Salvador schreef:
> > Move systemd service to xserver-nodm-init-systemd to be consistent with
> > other packages.
> >
> > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>
> I'm not going to merge such patches unless a reasonable effort has been
> made
> to tasks/images using the packages in question.
> The breakage caused by patches like this is too subtle to notice
> immediately
> since doing $packagemanager upgrade will now silently remove the startup
> units. Similar breakage when using tasks, building images, etc.
>

This is fixing a  broken and completely wrong package change done by you
at 4ad7ec43564fd7ab9c5d50dfcccd4a59308dbcb1; this sholdn't have been done
this way and systemd is still not well set in Meta-OE. Images and tasks
using it (I use it) ought to keep an eye on change that might affect them.

I agree this is subtle but this needs to be done so we can get systemd
integration process further. You not merging this won't fix the problem.

The only missing change I noticed is in meta-efl and I will send another
patch for it in next pull request but do a second though about merging it,
please.

And I have the holidays off, so most patches need to wait till the second
> week of january.
>

No problem.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br



More information about the Openembedded-devel mailing list