[oe] [PATCH 08/13] cdparanoia (svn): use build variables to fix packaging when using empty prefix

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Wed Feb 16 20:41:44 UTC 2011


2011/2/16 Martin Jansa <martin.jansa at gmail.com>:
> On Wed, Feb 16, 2011 at 3:48 PM, Frans Meulenbroeks
> <fransmeulenbroeks at gmail.com> wrote:
>> Did a quick check. We have 24 other recipes that refer to ${D}/usr/bin:
>>
>> frans at frans-desktop:~/workspace/openembedded/recipes$ grep '${D}/usr/bin' */* -l
>
>> mokoeightball/mokoeightball_svn.bb
>> openmoko-3rdparty/openmoko-gps_0.0.1+svnr9.bb
>
> those 2 fixed, will push as soon as I get home..
>
>> Guess ideally these should all be fixed
>
> agreed, but be aware that sometimes fixing it in recipe is not enough
> and actuall code (like those 2 above) expects /usr/bin/
> so fixing it only in recipe would create recipe respecting
> bindir/datadir, but failing in runtime which is worse then not
> respecting bindir/datadir but with working runtime.
>

Actually I can imagine there are more of these. I only peeked at
${D}/usr/bin but I can imagine that e.g. ${D}/usr/lib gives more or
other hits.
And of course we should not break things. This is definitely not a
thing for an automated edit script or so.

Best regards, Frans




More information about the Openembedded-devel mailing list