[oe] [PATCH] bitbake.conf: Simplify TARGET_CPPFLAGS/LDFLAGS

[Denys Dmytriyenko]

On Mon, Feb 21, 2011 at 10:21:12PM -0800, Khem Raj wrote:
> On Mon, Feb 21, 2011 at 5:14 PM, Tom Rini <tom_rini at mentor.com> wrote:
> > This is based on poky's ba2e1f4d933c37b372d6749d64614f2510ee9d7b, which
> > simplifies TARGET_CPPFLAGS (and thus CFLAGS) and TARGET_LDFLAGS
> > based on gcc any company having --sysroot
> >
> > Signed-off-by: Tom Rini <tom_rini at mentor.com>
> 
> Acked-by:Khem Raj <raj.khem at gmail.com>

Tom, Khem,

This change seems to break external-toolchains, e.g. CodeSourcery Lite, at 
least 2009q1 (gcc-4.3 based)...

I'm seeing issues like this in libxau:

| ./include/X11/Xauth.h:48:31: error: X11/Xfuncproto.h: No such file or directory
| ./include/X11/Xauth.h:49:27: error: X11/Xfuncs.h: No such file or directory

It cannot find standard X headers from OE sysroot.

Do I need to pass an extra --sysroot to CSL? Any other pointers?
Here's (hopefully useful) info from my toolchain:

$ arm-none-linux-gnueabi-gcc -print-sysroot
/opt/arm-2009q1/bin/../arm-none-linux-gnueabi/libc

$ arm-none-linux-gnueabi-gcc -print-search-dirs
install: /opt/arm-2009q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/
programs: =/opt/arm-2009q1/bin/../libexec/gcc/arm-none-linux-gnueabi/4.3.3/:/opt/arm-2009q1/bin/../libexec/gcc/:/opt/arm-2009q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/../../../../arm-none-linux-gnueabi/bin/arm-none-linux-gnueabi/4.3.3/:/opt/arm-2009q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/../../../../arm-none-linux-gnueabi/bin/
libraries: =/opt/arm-2009q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/:/opt/arm-2009q1/bin/../lib/gcc/:/opt/arm-2009q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/../../../../arm-none-linux-gnueabi/lib/arm-none-linux-gnueabi/4.3.3/:/opt/arm-2009q1/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/../../../../arm-none-linux-gnueabi/lib/:/opt/arm-2009q1/bin/../arm-none-linux-gnueabi/libc/lib/arm-none-linux-gnueabi/4.3.3/:/opt/arm-2009q1/bin/../arm-none-linux-gnueabi/libc/lib/:/opt/arm-2009q1/bin/../arm-none-linux-gnueabi/libc/usr/lib/arm-none-linux-gnueabi/4.3.3/:/opt/arm-2009q1/bin/../arm-none-linux-gnueabi/libc/usr/lib/

-- 
Denys


> > ---
> >  conf/bitbake.conf |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/conf/bitbake.conf b/conf/bitbake.conf
> > index f005658..ec20332 100644
> > --- a/conf/bitbake.conf
> > +++ b/conf/bitbake.conf
> > @@ -502,7 +502,7 @@ PATCHRESOLVE = 'noop'
> >
> >  export BUILD_CPPFLAGS = "-isystem${STAGING_INCDIR_NATIVE}"
> >  export CPPFLAGS = "${TARGET_CPPFLAGS}"
> > -export TARGET_CPPFLAGS = "-isystem${STAGING_DIR_TARGET}${includedir}"
> > +export TARGET_CPPFLAGS = ""
> >  export SDK_CPPFLAGS = "-isystem${STAGING_DIR_SDK}${includedir} -isystem${STAGING_DIR_HOST}${includedir}"
> >
> >  export BUILD_CFLAGS = "${BUILD_CPPFLAGS} ${BUILD_OPTIMIZATION}"
> > @@ -520,7 +520,7 @@ export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \
> >                         -Wl,-rpath,${STAGING_LIBDIR_NATIVE} -Wl,-O1"
> >
> >  export LDFLAGS = "${TARGET_LDFLAGS}"
> > -export TARGET_LDFLAGS = '${@["-L${STAGING_DIR_TARGET}${libdir} -Wl,-rpath-link,${STAGING_DIR_TARGET}${libdir} -Wl,-O1 ${TARGET_LINK_HASH_STYLE}", "-Wl,-O1 ${TARGET_LINK_HASH_STYLE}"][bb.data.getVar('LIBTOOL_HAS_SYSROOT', d, 1) == "yes"]}'
> > +export TARGET_LDFLAGS = "-Wl,-O1 ${TARGET_LINK_HASH_STYLE}"
> >
> >  export SDK_LDFLAGS = "-L${STAGING_DIR_SDK}${libdir} \
> >                          -Wl,-rpath-link,${STAGING_DIR_SDK}${libdir} \
> > --
> > 1.7.0.4
> >
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel