[oe] [PATCH 10/12] busybox: simplify update-rc.d OPT handling

[Roman I Khimov]

В сообщении от Понедельник 03 января 2011 23:02:04 автор Bernhard Reutner-
Fischer написал:
> -	if test "x$D" != "x"; then
> -		OPT="-r $D"
> -	else
> -		OPT="-s"
> -	fi
> +	[ -n "$D" ] && OPT="-r $D" || OPT="-s"

I have a strong feeling that this is wrong. Yeah, the first one takes up five 
times more lines but to me it's about five times easier to parse glancing over 
the recipe.

Also, from what I heard '"x$D" != "x"' tests are the most portable ones.

-- 
 http://roman.khimov.ru
mailto: roman at khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110103/82514021/attachment-0002.sig>