[oe] [PATCH 09/12] busybox: provide postrm for package mdev

Otavio Salvador otavio at ossystems.com.br
Wed Jan 12 11:07:06 UTC 2011


On Tue, Jan 11, 2011 at 17:41, Bernhard Reutner-Fischer
<rep.dot.nop at gmail.com> wrote:
> On Tue, Jan 04, 2011 at 01:54:04PM +0100, Wolfgang Hauser wrote:
>>I agree for the test statement, but that may be solved by using ´the
>>brackets in the long statement.
>>
>>Otavio Salvador schrieb:
>>> On Tue, Jan 4, 2011 at 09:58, Wolfgang Hauser <wohauser at gmx.de> wrote:
>>>> Keep it simple and stupid!
>>>> So I vote for the long, readable and less error prone version.
>>>
>>> I usually prefer the KISS however on this specific case I disagree.
>>>
>>> The new code avoid using test and a fork. This allows for "test"
>>> applet removal if desired.
>>>
>>> I prefer the ugly but more "embedded like" code.
>
> remember that this stuff potentially ends up on the target, so KISS
> (byte-wise) is always the preferred way. And yes, update-rc.d and the
> required inode itself is bloat, but heck, if you want online
> pkg-management you have to take that penalty, FWIW.
>
> So.. Can i please have an explicit ACK for that space-saver?

Acked-by: Otavio Salvador <otavio at ossystems.com.br>

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br




More information about the Openembedded-devel mailing list