[oe] [PATCH] python-scons_1.3.0: add missing dependencies
Víctor M. Jáquez L.
vjaquez at igalia.com
Tue Jan 25 16:18:39 UTC 2011
On Tue, Jan 25, 2011 at 04:59:25PM +0100, Koen Kooi wrote:
> Some small nitpicks, see below
>
> Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
>
> > In order to launch scons in a board it depends on a couple python packages
> > which were not managed by the recipe.
> >
[snip]
>
> We generally put variables in the order OE uses them, so RDEPENDS should go
> next to do_package/FILES/etc. Historically it was on top, but that stopped
> making sense after switching to RDEPENDS_${PN}
Done.
>
> > LICENSE = "GPL"
>
> Could you fix that while you're at it? It would be nice to know if it's
> GPLv2 or GPLv2+.
Verified. It is MIT not GPL!
>
> Other than that, the patch looks OK to me[1].
>
> regards,
>
> Koen
>
> [1] Sconstructs still make my eyes bleed, but that's not the point
I do not like it either at all, but v8 uses it.
vmjl
More information about the Openembedded-devel
mailing list