[oe] [RFC][PATCH] binconfig.bbclass: search configs in PKGD instead of S

[Khem Raj]

On Thu, Jan 27, 2011 at 2:31 PM, Stanislav Brabec <utx at penguin.cz> wrote:
> Hallo.
>
> It seems that searching for binconfig in S makes more problems than it
> brings benefits. It breaks for example ncurses - it populates
> ncurses-config instead of ncurses5-config and ncursesw5-config).
>
> Searching in the installed root seems to be more logical.
>
> Most packages don't need to be ported to this change, as they install
> config file with the same name as it exists in sources. But probably
> several will need porting.

Yes this patch looks sane to me.

>
> --- a/classes/binconfig.bbclass
> +++ b/classes/binconfig.bbclass
> @@ -49,7 +49,7 @@
>  SYSROOT_PREPROCESS_FUNCS += "binconfig_sysroot_preprocess"
>
>  binconfig_sysroot_preprocess () {
> -       for config in `find ${S} -name '${BINCONFIG_GLOB}'`; do
> +       for config in `find ${PKGD} -name '${BINCONFIG_GLOB}'`; do
>                configname=`basename $config`
>                install -d ${SYSROOT_DESTDIR}${STAGING_BINDIR_CROSS}
>                cat $config | sed ${@get_binconfig_mangle(d)} > ${SYSROOT_DESTDIR}${STAGING_BINDIR_CROSS}/$configname
>
> --
>
> ________________________________________________________________________
> Stanislav Brabec
> http://www.penguin.cz/~utx/zaurus
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>