[oe] [oe-commits] Andrea Adami : kernel.bbclass: remove unintended change of INITRAMFS_TASK

Andrea Adami andrea.adami at gmail.com
Thu Jul 14 22:46:36 UTC 2011


On Thu, Jul 14, 2011 at 4:41 PM, git version control
<git at git.openembedded.org> wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: df31400ef89c14b45860feb906d4355d5f7de0c7
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=df31400ef89c14b45860feb906d4355d5f7de0c7
>
> Author: Andrea Adami <andrea.adami at gmail.com>
> Date:   Thu Jul 14 00:50:26 2011 +0200
>
> kernel.bbclass: remove unintended change of INITRAMFS_TASK
>
> * during an unfortunate round of tests right before commiting the patch
> * do_configure[depends] became  kernel_do_configure[depends]
> * Nonsense!
> * As documented in commit 4dfef62dfe54a3b2c557a6df81d155adc1e03ccb
> * of OpenEmbedded git server, this must be in do_configure[depends]
> * to do the magic.
>
> Signed-off-by: Andrea Adami <andrea.adami at gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>
> ---
>
>  meta/classes/kernel.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index b71a650..d1f6480 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -195,7 +195,7 @@ kernel_do_configure() {
>        fi
>  }
>
> -kernel_do_configure[depends] += "${INITRAMFS_TASK}"
> +do_configure[depends] += "${INITRAMFS_TASK}"
>
>  do_menuconfig() {
>         export DISPLAY='${DISPLAY}'
>
>
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits


Hello,

just FYI I was confused by the kernel.bbclass in meta-openembedded.
This one has the kernel_do_configure[depends].

I'd suggest to remove this kernel.bbclass asap, merging eventual
missing bits in oe-core.
(At least apply this same fix as in oe-core)

Regards

Andrea




More information about the Openembedded-devel mailing list