[oe] [RFC meta-efl] e(fl).bbclass: don't override PACKAGES, but add to it

Koen Kooi koen at dominion.thruhere.net
Tue Jul 26 07:03:55 UTC 2011


Op 26 jul. 2011, om 09:00 heeft Martin Jansa het volgende geschreven:

> On Tue, Jul 26, 2011 at 08:52:57AM +0200, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
>> ---
>> meta-efl/classes/e.bbclass   |    6 +++---
>> meta-efl/classes/efl.bbclass |    4 ++--
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>> 
>> diff --git a/meta-efl/classes/e.bbclass b/meta-efl/classes/e.bbclass
>> index 88a1f6a..ebf1da8 100644
>> --- a/meta-efl/classes/e.bbclass
>> +++ b/meta-efl/classes/e.bbclass
>> @@ -18,9 +18,9 @@ do_configure_append() {
>> export CURL_CONFIG = "${STAGING_BINDIR_CROSS}/curl-config"
>> export FREETYPE_CONFIG = "${STAGING_BINDIR_CROSS}/freetype-config"
>> 
>> -# This construction is stupid, someone with more E knowledge should change it to =+ or something
>> -# And it's in efl.bbclass as well....
>> -PACKAGES = "${PN}-dbg ${PN}-themes ${PN} ${PN}-dev ${PN}-doc ${PN}-lib ${PN}-static"
>> +PACKAGES =+ "${PN}-themes"
>> +PACKAGES += "${PN}-lib ${PN}-tests"
> 
> ${PN}-tests wasn't in original PACKAGES
> 
>> FILES_${PN}-lib = "${libdir}/lib*.so.*"
>> FILES_${PN}-themes = "${datadir}/${PN}/themes ${datadir}/${PN}/data ${datadir}/${PN}/fonts ${datadir}/${PN}/pointers ${datadir}/${PN}/images ${datadir}/${PN}/users ${datadir}/${PN}/images ${datadir}/${PN}/styles"
>> FILES_${PN}-dev += "${includedir} ${libdir}/lib*.so"
>> diff --git a/meta-efl/classes/efl.bbclass b/meta-efl/classes/efl.bbclass
>> index 2dc6fc2..c831439 100644
>> --- a/meta-efl/classes/efl.bbclass
>> +++ b/meta-efl/classes/efl.bbclass
>> @@ -19,8 +19,8 @@ do_install_prepend () {
>> 	done
>> }
>> 
>> -# This construction is stupid, someone with more E knowledge should change it to =+ or something
>> -PACKAGES = "${PN}-dbg ${PN} ${PN}-themes ${PN}-dev ${PN}-doc ${PN}-tests ${PN}-static"
>> +PACKAGES =+ "${PN}-themes"
>> +PACKAGES += "${PN}-lib ${PN}-tests"
> 
> ${PN}-lib wasn't in original PACKAGES

I did that to keep them in sync between the 2 classes. I can restore them to the original settings if you wish, I have no strong preference either way.

regards,

Koen



More information about the Openembedded-devel mailing list