[oe] [meta-oe] patch review for meta-oe (was: [meta-oe][PATCH] rp-pppoe: Port from oe.dev)

[Paul Menzel]

Dear Koen, dear Tom,


I am surprised that you applied Tom’s patch without incorporating my
review.

        commit 77d31f8d3027f6ef96bff61da4bf22cf9618bf21
        Author:     Tom Rini <tom_rini at mentor.com>
        AuthorDate: Wed Jul 27 03:46:52 2011 +0000
        Commit:     Koen Kooi <koen at dominion.thruhere.net>
        CommitDate: Tue Jul 26 21:51:39 2011 +0200
        
            rp-pppoe: Port from oe.dev
            
            The difference between this and oe.dev are:
            - Reset PR
            - Add bitfields site variable to the endian site file
              This was wrong in oe.dev for BE (mips).
            - Add LIC_FILES_CHKSUM
            
            Signed-off-by: Tom Rini <tom_rini at mentor.com>
            Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>

First of all, the dates do not make any sense at all, so it looks like
you applied it already three minutes after Tom had sent the patch.

I would suggest, that patches get a little more time for review before
you apply them, which is of course disadvantageous for people wanted to
see their patches applied right away.

But I would like to prevent that “messy” patches get applied to the new
repositories to get a better quality.

So Tom, it would be nice if you could sent improvement patches to fix
the `HOMEPAGE` field, the patch headers and the whitespace. The `PR`
cannot be fixed now.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110727/f259fe7f/attachment-0002.sig>