[oe] [?PATCH] mplayer: fix linker error

[Paul Menzel]

Dear Josua,


thank you for your patch. A couple of remarks.

Am Samstag, den 30.07.2011, 18:14 +0200 schrieb Josua Mayer:
> From: = <=>

1. Please fix this line above.
2. If there are several recipe versions, also note in the commit summary
which version you changed.

	mplayer_git: fix linker error

> * use already existing patch fix-emu_qtx_api.diff

3. Your Signed-off-by line is missing. Please read our commit policy
[1]. Please also read the other policies and howtos [3][4].
4. Somehow a question mark slipped into the patch tag in the
subject/commit summary: `[?PATCH]`. Please resend your patch with a
correct line, so that our patch queue can pick your patch up [2].
5. One question regarding your patch. What build configuration do you
use? With `angstrom-2010.x` for `MACHINE = "beagleboard"` it works fine.
For `minimal` with the same machine it fails with the following error.

| Checking for LIVE555 Streaming Media libraries ... yes
| Checking for FFmpeg (libavutil libavcodec libavformat libswscale libpostproc) ...
| Error: Unable to find development files for some of the FFmpeg libraries above. Aborting. If you really mean to compile without FFmpeg support use --disable-ffmpeg.
|
| Check "config.log" if you do not understand why it failed.

So I am wondering why you experience this error.

> ---
>  recipes/mplayer/mplayer_git.bb |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/mplayer/mplayer_git.bb b/recipes/mplayer/mplayer_git.bb
> index 259ce99..5f15618 100644
> --- a/recipes/mplayer/mplayer_git.bb
> +++ b/recipes/mplayer/mplayer_git.bb
> @@ -8,6 +8,7 @@ DEPENDS = "libvpx live555 libdvdread libtheora virtual/libsdl ffmpeg xsp zlib li
>  RDEPENDS_${PN} = "mplayer-common"
>  LICENSE = "GPL"
>  SRC_URI = "git://repo.or.cz/mplayer/glamo.git;protocol=git;branch=mplayer2 \
> +	file://fix-emu_qtx_api.diff \
>     "
>  
>  SRC_URI_append_armv7a = " \


Thanks,

Paul


[1] http://openembedded.org/index.php/Commit_Policy
[2] http://patches.openembedded.org/project/oe/list/
[3] http://openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded
[4] http://openembedded.org/index.php/Commit_Patch_Message_Guidelines
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110730/d9a0ce65/attachment-0002.sig>