[oe] [PATCH 1/1] matrix_gui: Update SRCREV

[Jeff Lance]

Paul,

Thanks for the help. I will use -s now. Previously I was hand typing in the
commit message.
I will resubmit a corrected version of this patch.

Jeff Lance

On Mon, Jun 6, 2011 at 9:35 AM, Paul Menzel <
paulepanter at users.sourceforge.net> wrote:

> Dear Jeff,
>
> Am Montag, den 06.06.2011, 09:15 -0500 schrieb Jeff Lance:
>
> you can make the commit subject more informational by writing the
> following.
>
>        matrix_gui: Update SRCREV to revision 257
>
> >       * Adding arm only multimedia apps to am37x
> >       * Wifi updates to am37x, am180x
> >       * Adding to am180x, am37x, am35x, beagle:
> >               * Oprofile example
>
> do you copy those lines from `git log`? `git log` adds indentation in
> front of the commit message. Please use `git format-patch`.
>
> > Signed-off-by  Jeff Lance   <j-lance1 at ti.com>
>
> A colon »:« is missing and it is formatting strangely. Please use the
> option `-s`.
>
> As I wrote often enough please make sure the From and Signed-off-by
> field match.
>
> > ---
> >  recipes/ti/matrix-gui-common_1.4.bb |    4 ++--
> >  recipes/ti/matrix-gui-e_1.3.bb      |    4 ++--
> >  recipes/ti/matrix-gui_1.3.bb        |    4 ++--
> >  3 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/recipes/ti/matrix-gui-common_1.4.bb b/recipes/ti/
> matrix-gui-common_1.4.bb
> > index 6f7376d..0b4b25b 100644
> > --- a/recipes/ti/matrix-gui-common_1.4.bb
> > +++ b/recipes/ti/matrix-gui-common_1.4.bb
> > @@ -4,5 +4,5 @@ require matrix-gui-common.inc
> >  # prebuilt version in the repository.
> >  RRECOMMENDS_${PN} = "am-sysinfo"
> >
> > -SRCREV = "249"
> > -PR = "${INC_PR}.10"
> > +SRCREV = "257"
>
> Would it be beneficial to add `SRCREV` to `matrix-gui.inc` and require
> that everywhere?
>
> > +PR = "${INC_PR}.11"
> > diff --git a/recipes/ti/matrix-gui-e_1.3.bb b/recipes/ti/
> matrix-gui-e_1.3.bb
> > index 8f2df1c..a6eb17f 100644
> > --- a/recipes/ti/matrix-gui-e_1.3.bb
> > +++ b/recipes/ti/matrix-gui-e_1.3.bb
> > @@ -1,5 +1,5 @@
> >  require matrix-gui-e.inc
> >
> > -SRCREV = "249"
> > -PR = "${INC_PR}.9"
> > +SRCREV = "257"
> > +PR = "${INC_PR}.10"
> >
> > diff --git a/recipes/ti/matrix-gui_1.3.bb b/recipes/ti/matrix-gui_1.3.bb
> > index f7e56a3..51678df 100644
> > --- a/recipes/ti/matrix-gui_1.3.bb
> > +++ b/recipes/ti/matrix-gui_1.3.bb
> > @@ -1,4 +1,4 @@
> >  require matrix-gui.inc
> >
> > -SRCREV = "249"
> > -PR = "${INC_PR}.5"
> > +SRCREV = "257"
> > +PR = "${INC_PR}.6"
>
> Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
>
> I did not build or runtest though.
>
>
> Thanks,
>
> Paul
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>