[oe] [PATCH] linphone: added recipe for v3.4.3

[Martin Jansa]

On Tue, Jun 07, 2011 at 03:23:54PM +0200, Guillaume BERAUDO wrote:
> Sorry, I missed your other comments.
> See below for my answers.
> 
> > > --git a/recipes/linphone/linphone-common_3.4.3.inc
> > > b/recipes/linphone/linphone-common_3.4.3.inc new file mode 100644
> > > index 0000000..5865ab0 --- /dev/null
> > > +++ b/recipes/linphone/linphone-common_3.4.3.inc
> > > @@ -0,0 +1,11 @@
> > > +
> > > +SRC_URI =
> > > "${SAVANNAH_MIRROR}/releases/linphone/3.4.x/sources/linphone-3.4.3.tar.gz
> > > \
> > > +	file://cif10fps.patch"
> > where is this file?
> 
> It is a mistake, this patch should not be added.
> 
> 
> 
> > > +require linphone-common.inc
> > > diff --git a/recipes/linphone/linphone_3.4.3+nogtk.bb
> > > b/recipes/linphone/linphone_3.4.3+nogtk.bb new file mode 100644
> > > index 0000000..9bec7b1
> > > --- /dev/null
> > > +++ b/recipes/linphone/linphone_3.4.3+nogtk.bb
> >
> > what does +nogtk mean in version?
> 
> It is possible to compile linphone with or without gtk GUI.

then I think it's better as part of package name
linphone-nogtk_3.4.3

otherwise you risk user getting upgrade on target
from linphone-3.4.3+nogtk to linphone-3.4.4+gtk

> I wrote another recipe for linphone 3.4.3 with gtk GUI.
> It will be sent for review later.
> 
> 
> > > @@ -0,0 +1,9 @@
> > > +DESCRIPTION = "Audio/video SIP-based IP phone (console edition)"
> > > +HOMEPAGE = "http://www.linphone.org/?lang=us"
> > > +LICENSE = "GPLv2"
> > > +PR="r6"
> > > +
> > > +DEFAULT_PREFERENCE = "2"
> > 
> > why D_P = "2" when all other recipes have default D_P = "1" and this
> > has highest PV?
> 
> Ok, I will correct it.
> 
> 
> > 
> > > +OVERRIDES_append = ":video:console"
> > 
> > This looks like someone trying to implement USE flags in OE :). But
> > I'm not sure it's right way and I haven't noticed this used in any
> > other recipe. So it would be better to discuss first.
> 
> I am new to openembedded and thus may have missed something in the
> documentations. Can you point me to some elegant way to implement
> recipe flavours?

I don't think TSC agreed on some sort of USE-flag solution or policy
yet, but keeping shared EXTRA_OECONF in linphone-3.4.3.inc and then
EXTRA_OECONF_append with nogtk specific options in separate files like
linphone-nogtk_3.4.3.bb would be easier to understand (at least to me),
even when not so "elegant" as your OVERRIDES solution.

Regards,
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110607/cdf48f83/attachment-0002.sig>