[oe] [PATCH] linphone: added recipe for v3.4.3

[Martin Jansa]

On Tue, Jun 07, 2011 at 04:23:58PM +0200, Guillaume BERAUDO wrote:
> Martin,
> 
> > > > what does +nogtk mean in version?
> > > 
> > > It is possible to compile linphone with or without gtk GUI.
> > 
> > then I think it's better as part of package name
> > linphone-nogtk_3.4.3
> > 
> > otherwise you risk user getting upgrade on target
> > from linphone-3.4.3+nogtk to linphone-3.4.4+gtk
> 
> Ok, I will change this.
> 
> 
> > > > > +OVERRIDES_append = ":video:console"
> > > > 
> > > > This looks like someone trying to implement USE flags in OE :).
> > > > But I'm not sure it's right way and I haven't noticed this used
> > > > in any other recipe. So it would be better to discuss first.
> > > 
> > > I am new to openembedded and thus may have missed something in the
> > > documentations. Can you point me to some elegant way to implement
> > > recipe flavours?
> > 
> > I don't think TSC agreed on some sort of USE-flag solution or policy
> > yet, but keeping shared EXTRA_OECONF in linphone-3.4.3.inc and then
> > EXTRA_OECONF_append with nogtk specific options in separate files like
> > linphone-nogtk_3.4.3.bb would be easier to understand (at least to
> > me), even when not so "elegant" as your OVERRIDES solution.
> 
> There is also some conditionnals with the DEPENDS.
> What is the use of all the "DEPENDS_some-package-name" directives?
> Isn't it identical to only use the global "DEPENDS"?

Yes it looks weird and broken on quick glance.
but "shared" DEPENDS = "foo" in linphone-3.4.3.inc and DEPENDS_append = "gtk+"
in linphone-gtk_1.2.4.bb makes sense
 
> I removed all the RDEPENDS stuff. Can you confirm it was unnecessary?

all linked .so providers should be picked to rdepends automatically by
package.bbclass so only extra stuff like linphone-gtk-config would be
needed in extra RDEPENDS_${PN} in linphone-gtk_1.2.4.bb.

> 
> Regards,
> 
> Guillaume

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110607/b686f9b4/attachment-0002.sig>