[oe] [PATCH 05/14] cmake.bbclass: use 2.8 modules

[Khem Raj]

On (23/02/11 13:47), Otavio Salvador wrote:
> On Wed, Feb 23, 2011 at 13:41, Phil Blundell <philb at gnu.org> wrote:
> > On Wed, 2011-02-23 at 13:07 +0000, Otavio Salvador wrote:
> >> -  echo "set( CMAKE_MODULE_PATH ${STAGING_DIR_NATIVE}/usr/share/cmake-2.6/Modules/ )" >> ${WORKDIR}/toolchain.cmake
> >> +  echo "set( CMAKE_MODULE_PATH ${STAGING_DIR_NATIVE}/usr/share/cmake-2.8/Modules/ )" >> ${WORKDIR}/toolchain.cmake
> >
> > This seems a bit fragile (and, presumably, is bad news for anybody who
> > is still using cmake 2.6 for any reason).  Isn't there any way to
> > automatically select the version that matches
> > ${STAGING_BINDIR_NATIVE}/cmake or whatever?
> 
> I see noone using cmake 2.6.
> 
> In any case cmake will know the "internal" modules directory by itself
> so it works even if this value doesn't match. This is where it is
> going to look as fallback and I was using 2.8 without 2.6 for long
> time without noticing any issue.
> 
> This seems safe. We could drop the CMAKE_MODULE_PATH if preferred. I
> just fixed it to 2.8 to reflect the current default one.

yeah make it portable for future if no one is using cmake 2.6

> 
> -- 
> Otavio Salvador                             O.S. Systems
> E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
-Khem