[oe] [PATCH v2 0/2] allow linux-lib-headers with external-toolchain-csl
Ben Gardiner
bengardiner at nanometrics.ca
Wed Mar 2 17:25:05 UTC 2011
Hi Tom and Denys,
On Wed, Mar 2, 2011 at 12:10 PM, Tom Rini <tom_rini at mentor.com> wrote:
>
> It's all in now (and this spurred me to push something else I've been
> meaning to for a while, adding in gdbserver and dropping do_stage)[...]
Ok, no worries then. I'm really glad that you found it useful, Tom and
it's making its way to upstream, thanks.
On Wed, Mar 2, 2011 at 12:10 PM, Tom Rini <tom_rini at mentor.com> wrote:
> [...]but in
> short, we just cp -a like before but now will rm -rf as needed.
On Wed, Mar 2, 2011 at 12:12 PM, Denys Dmytriyenko <denys at ti.com> wrote:
> Looks good to me, except:
>
> 1. Why use rsync instead of cp? I think it's less portable that way.
I had an inkling that my selection of rsync should have been defended
in the commit messages :)
In my own defense, I was concerned that the cp followed by an rm could
remove from staging other headers that were installed into the correct
locations -- rsync is my go-to for copying with exclusions.
I'll remember that it is not portable enough next time around.
On Wed, Mar 2, 2011 at 12:12 PM, Denys Dmytriyenko <denys at ti.com> wrote:
> 2. I saw several linux-lib-headers instead of linux-libc-headers (missing 'c')
On Wed, Mar 2, 2011 at 12:16 PM, Denys Dmytriyenko <denys at ti.com> wrote:
> Argh, you left one linux-lib-headers in the comment... :)
Oops. Sorry about that.
Thanks again for picking up this patch.
Best Regards,
Ben Gardiner
---
Nanometrics Inc.
http://www.nanometrics.ca
More information about the Openembedded-devel
mailing list