[oe] [PATCH] gsoap_2.7.13 build errors

[Paul Menzel]

Dear Peter,


Am Freitag, den 11.03.2011, 11:38 +0100 schrieb Peter Gsellmann:
> There is a compiler error about an impossible cast from QUIRKS* to const QUIRKS*
> The patches are from Fedora12 which has the exact same gsoap-version
> They can be found at http://archive.fedoraproject.org/pub/archive/fedora/linux/releases/12/Everything/source/SRPMS/gsoap-2.7.13-2.fc12.src.rpm
> 
> In the native package, the generated binary is installed in STAGING_BINDIR_NATIVE where expected by the gsoap-package
> 
> Otherwise the gsoap-package uses a soapcpp2 delivered as 32bit-executable in the source-package! This fails on x86_64 hosts.

smaller patches would it make easier to review in my opinion. (If it
were possible.)

On what did you test this patch?

> Signed-off-by: Peter Gsellmann <pgsellmann at portner-elektronik.at>
> ---
>  recipes/gsoap/gsoap-2.7.13/gsoap-2.7-openssl.patch |   17 +++++
>  recipes/gsoap/gsoap-2.7.13/unused_args.patch       |   39 +++++++++++
>  .../gsoap/gsoap-2.7.13/use_libtool-2.7.12.patch    |   72 ++++++++++++++++++++
>  recipes/gsoap/gsoap-native_2.7.13.bb               |    3 +-
>  recipes/gsoap/gsoap_2.7.13.inc                     |    4 +-
>  5 files changed, 133 insertions(+), 2 deletions(-)
>  create mode 100644 recipes/gsoap/gsoap-2.7.13/gsoap-2.7-openssl.patch
>  create mode 100644 recipes/gsoap/gsoap-2.7.13/unused_args.patch
>  create mode 100644 recipes/gsoap/gsoap-2.7.13/use_libtool-2.7.12.patch

[…]

> diff --git a/recipes/gsoap/gsoap-native_2.7.13.bb b/recipes/gsoap/gsoap-native_2.7.13.bb
> index 3e905e7..83c2329 100644
> --- a/recipes/gsoap/gsoap-native_2.7.13.bb
> +++ b/recipes/gsoap/gsoap-native_2.7.13.bb
> @@ -6,8 +6,9 @@ EXTRA_OEMAKE = ""
>  
>  inherit native
>  
> +

Not needed?

>  do_install() {
> -	:
> +	install -m 0755 ${S}/gsoap/src/soapcpp2 ${STAGING_BINDIR_NATIVE}/
>  }
>  
> 
> diff --git a/recipes/gsoap/gsoap_2.7.13.inc b/recipes/gsoap/gsoap_2.7.13.inc
> index 877e1d1..c3ab3c4 100644
> --- a/recipes/gsoap/gsoap_2.7.13.inc
> +++ b/recipes/gsoap/gsoap_2.7.13.inc
> @@ -3,7 +3,9 @@ for the development of SOAP Web Services and clients."
>  SECTION = "devel"
>  LICENSE = "GPL"
>  
> -SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz"
> +SRC_URI = "${SOURCEFORGE_MIRROR}/gsoap2/gsoap_${PV}.tar.gz	\
> +	file://gsoap-2.7-openssl.patch	\

Use spaces instead of tabulators before »\«?

> +	file://unused_args.patch"

Maybe you can move the quote »"« on a new line, so that future patches
will not create a difference for that line.

>  inherit autotools


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110311/5f1eecbd/attachment-0002.sig>