[oe] [PATCH] xfce_session_4.6.{1, 2}: explicitly pass the path of `iceauth`

[Paul Menzel]

Am Samstag, den 19.03.2011, 21:32 -0700 schrieb Khem Raj:
> On 3/19/2011 6:10 PM, Paul Menzel wrote:
> > Am Samstag, den 19.03.2011, 11:33 -0700 schrieb Khem Raj:
> >> On (18/03/11 13:00), Paul Menzel wrote:
> >>> Date: Fri, 18 Mar 2011 12:03:43 +0100
> >>>
> >>> Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.
> >>>
> >>>          checking if the linker (arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi) is GNU ld... (cached) yes
> >>>          checking whether to build with profiling support... no
> >>>          checking whether to compile with coverage profiling instrumentation... no
> >>>          checking whether to disable assertions... no
> >>>          checking whether to build final version... yes
> >>>          checking whether arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi accepts -O1... yes
> >>>          checking for iceauth... no
> >>>          configure: error: iceauth missing, please check your X11 installation
> >>>
> >>> As suggested by Khem Raj [1] pass the value – `/usr/bin/iceauth` is taken – to the configure script so that the test is avoided.
> >>>
> >>> Therefore `iceauth` is removed from `DEPENDS` and the `PR` variable is incremented.
> >>>
> >>> This issue has been reported upstream as ticket #7420 [2].
> >>>
> >>> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/031115.html
> >>> [2] http://bugzilla.xfce.org/show_bug.cgi?id=7420
> >>>
> >>> Signed-off-by: Paul Menzel<paulepanter at users.sourceforge.net>
> >>> ---
> >>>   recipes/xfce-base/xfce4-session_4.6.1.bb |    6 ++++--
> >>>   recipes/xfce-base/xfce4-session_4.6.2.bb |    6 ++++--
> >>>   2 files changed, 8 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/recipes/xfce-base/xfce4-session_4.6.1.bb b/recipes/xfce-base/xfce4-session_4.6.1.bb
> >>> index ba66ac1..5029b21 100644
> >>> --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
> >>> +++ b/recipes/xfce-base/xfce4-session_4.6.1.bb
> >>> @@ -1,13 +1,15 @@
> >>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> >>> -DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> >>> +DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus xfce-utils"
> >>>   SECTION = "x11"
> >>>
> >>> -PR = "r4"
> >>> +PR = "r5"
> >>>
> >>>   inherit xfce46
> >>>
> >>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
> >>>
> >>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> >>
> >> Would it make sense to have iceauth-native instead ?
> >
> > It never really executes `iceauth` during compile time but just during
> > configure to determine the runtime path. So `iceauth-native` is not
> > needed and would be even result in the wrong path, I think.
> 
> weather it executes is during configure or during compile how does it 
> matter ?

That it is not a build time dependency and therefore only needed during
runtime. I thought the pathes of programs during compile time do not
matter since the build host and the host where it gets installed differ
when cross compiling.

> in the end it needs iceauth and it will mean that you will ask
> folks to have iceauth on their build host

No, they implemented it this way but it is wrong in my opinion.

> which is what I am asking to avoid.

I tried to do that.

> Either cache the variable

Is not my patch doing that?

> or use iceauth-native so this dep is removed from build host packages.
>
> >>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
> >>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
> >>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
> >>> diff --git a/recipes/xfce-base/xfce4-session_4.6.2.bb b/recipes/xfce-base/xfce4-session_4.6.2.bb
> >>> index d7f768a..c937775 100644
> >>> --- a/recipes/xfce-base/xfce4-session_4.6.2.bb
> >>> +++ b/recipes/xfce-base/xfce4-session_4.6.2.bb
> >>> @@ -1,13 +1,15 @@
> >>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> >>> -DEPENDS = "libwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> >>> +DEPENDS = "libwnck libxfcegui4 libxfce4util dbus xfce-utils"
> >>>   SECTION = "x11"
> >>>
> >>> -PR = "r0"
> >>> +PR = "r1"
> >>>
> >>>   inherit xfce46
> >>>
> >>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
> >>>
> >>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> >>> +
> >>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
> >>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
> >>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
> >>> --
> >>> 1.7.4.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110320/962be477/attachment-0002.sig>