[oe] [PATCH 1/2] TI IPC: Fixes for license, dependencies and installer unpack

[Paul Menzel]

Dear Siddharth,


Am Donnerstag, den 24.03.2011, 14:22 +0530 schrieb Siddharth Heroor:
> * Correct the license from TI to BSD.
> * Fix dependencies

Also full stop at the end. ;-)

> * Update the installer unpack commands for latest releases.
> 
> Signed-off-by: Siddharth Heroor <heroor at ti.com>
> ---
>  recipes/ti/ti-ipc.inc |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes/ti/ti-ipc.inc b/recipes/ti/ti-ipc.inc
> index cd6ad6e..28f8525 100644
> --- a/recipes/ti/ti-ipc.inc
> +++ b/recipes/ti/ti-ipc.inc
> @@ -1,20 +1,23 @@
>  DESCRIPTION = "TI Inter Process Ccommunication (IPC) Mechanisms (for
> Uni- and Multi- Processor Configurations)"

Your mailer mangled the patch by adding line breaks.

>  HOMEPAGE = "http://software-dl.ti.com/dsps/dsps_public_sw/sdo_sb/targetcontent/ipc/index.html"
> +

I think no empty line is needed [1].

>  SECTION = "devel"
> -LICENSE = "TI"
> +LICENSE = "BSD"
> 
>  require ti-paths.inc
>  require ti-staging.inc
>  require ti-eula-unpack.inc
> 
> -PR = "r2"
> +PR = "r3"
> 
>  S = "${WORKDIR}/ipc_${PV}"
> 
>  SRC_URI = "http://software-dl.ti.com/dsps/dsps_public_sw/sdo_sb/targetcontent/ipc/${PV}/exports/ipc_setuplinux_${PV}.bin;name=ipcbin"
> 
> +DEPENDS = "ti-sysbios ti-cgt6x ti-xdctools"
> +

Did it work before?

>  BINFILE="ipc_setuplinux_${PV}.bin"
> -TI_BIN_UNPK_CMDS="Y: qY:workdir:Y"
> +TI_BIN_UNPK_CMDS="Y: q:workdir:Y"

Will this work with the older versions, since it is an include file.

>  do_install() {
>      install -d ${D}${IPC_INSTALL_DIR_RECIPE}

Please resend as »PATCH v2«. Your other patch was also corrupted.

Two additional comments.

1. I would prefer one commit for each change.
2. Is it true that `ti-ipc` as committed in 32336b9a [1] was only usable
for the TI folks and just now it is released to and usable for the
public? This should be explained in the commit message and that the
first public version will be committed in the next commit.


Thanks,

Paul


[1] http://openembedded.org/index.php/Styleguide
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=32336b9a0e785f2f13d8cc36aefcaa2be27141da
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110324/cf367edb/attachment-0002.sig>