[oe] [PATCH] poppler 0.12.3: remove "default_preference = -1"

[Paul Menzel]

Dear Philippe,


Am Dienstag, den 29.03.2011, 10:56 +0200 schrieb Martin Jansa:
> On Tue, Mar 29, 2011 at 10:47:18AM +0200, Paul Menzel wrote:

> > please read the commit policy [1] and example [2] on how to format the
> > commit message. You do not have to resend this patch as I will edit the
> > commit message before pushing your patch.
> > 
> > Am Montag, den 28.03.2011, 21:33 +0300 schrieb phdeswer:
> > 
> > > remove default_preference game as everybody wants to use the latest
> > > version, but the default_prefernce is -1 so this fails building packages
> > > that depend on poppler if not used with a distro that has a preferred
> > > version or default_preference bump
> > 
> > Please note that you can always set your preferred version in
> > `conf/local.conf`.
> > 
> > > Signed-off-by: phdeswer <philippedeswert at gmail.com>
> > >
> > > ---
> > >  recipes/poppler/poppler_0.12.3.bb |    5 -----
> > >  1 files changed, 0 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/recipes/poppler/poppler_0.12.3.bb b/recipes/poppler/poppler_0.12.3.bb
> > > index 8b9fcca..ce1952e 100644
> > > --- a/recipes/poppler/poppler_0.12.3.bb
> > > +++ b/recipes/poppler/poppler_0.12.3.bb
> > > @@ -2,11 +2,6 @@ require poppler.inc
> > >  
> > >  DEPENDS += "lcms"
> > >  
> > > -DEFAULT_PREFERENCE = "-1"
> > > -DEFAULT_PREFERENCE_angstrom = "1"
> > > -DEFAULT_PREFERENCE_minimal = "1"
> > > -DEFAULT_PREFERENCE_minimal-uclibc = "1"
> > > -
> > >  EXTRA_OECONF_append = " --disable-abiword-output "
> > >  
> > >  RDEPENDS_${PN} = "poppler-data"
> > 
> > Do all distribution maintainers agree with this patch? I do not see a
> > problem since it has been used in tested in Ȧngström and
> > minimal{,-uclibc} for over six months.
> 
> and in SHR too (pinned in preferred-shr-versions.inc), feel free to
> remove it there too.
> 
> Acked-by: Martin Jansa <Martin.Jansa at gmail.com>
> 
> > Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>

I pushed the edited patch in bb63320b [3]. Philippe, please update the
state of your patch in the patch queue [4], since I do not have the
permissions to do so.

        bin/pwclient update -s Accepted -c bb63320bc4c955c51619d73cfc622001d602911a 1837


Thanks,

Paul


> > [1] http://openembedded.org/index.php/Commit_Policy
> > [2] http://openembedded.org/index.php/Commit_log_example
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=bb63320bc4c955c51619d73cfc622001d602911a
[4] http://openembedded.org/index.php/Patchwork
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110329/085c02ab/attachment-0002.sig>