[oe] [PATCH 1/8] illume-keyboards-shr: add LICENSE

Thu Mar 31 21:20:42 UTC 2011

On Thu, Mar 31, 2011 at 02:13:27PM -0700, Khem Raj wrote:
> On Thu, Mar 31, 2011 at 2:11 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
> > On Thu, Mar 31, 2011 at 02:03:23PM -0700, Khem Raj wrote:
> >> On Thu, Mar 31, 2011 at 1:53 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
> >> > On Thu, Mar 31, 2011 at 01:40:38PM -0700, Khem Raj wrote:
> >> >> On Thu, Mar 31, 2011 at 2:14 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> >> >> > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> >> >>
> >> >> I hope you made sure that all license files in a package source are checksummed.
> >> >
> >> > I've added LICENSE file only in case that package sources doesn't have
> >> > any licensing information (simple scripts without header etc) like in
> >> > this case
> >> > http://git.shr-project.org/git/?p=illume-keyboards.git;a=tree
> >> >
> >> > For all e-wm/efl/illume related recipes we have mostly in meta-shr I've
> >> > used LICENSE file from enlightenment repo, because our versions usually
> >> > just modifies original versions a bit so for me as not-a-lawyer-at-all
> >> > it makes sense to use same LICENSE.
> >>
> >>
> >> thats fine as long as we dont miss any new licenses. You can also chop of
> >> portions of source files with startline and endline in checksumming licenses
> >> if there is no explicit LICENSE file
> >
> > I know and I've used this in couple of recipes already, but there
> > sometimes there really is nothing..
> 
> if there is nothing then let it be so I would think and state no license

that's why I had and still have in few recipes
LICENSE = "unknown"
without it I cannot even parse recipes

but
package_qa_check_license() in insane.bbclass does not allow empty
LIC_FILES_CHKSUM so I had to resolve it somehow

In most shr cases I can just push LICENSE file to upstream repo and bump
SRCREV if latest rev is OK.. but adding LICENSE file to OE was just
faster and easier for me.

Cheers,

> 
> >
> >> > Cheers,
> >> >
> >> >> whole series is ok where I had question I replied to individual patch
> >> >>
> >> >> Acked-by: Khem Raj <raj.khem at gmail.com>
> >> >>
> >> >> > ---
> >> >> >  .../recipes-efl/e17/illume-keyboards-shr/LICENSE   |   25 ++++++++++++++++++++
> >> >> >  .../recipes-efl/e17/illume-keyboards-shr_git.bb    |    7 +++--
> >> >> >  2 files changed, 29 insertions(+), 3 deletions(-)
> >> >> >  create mode 100644 meta-efl/recipes-efl/e17/illume-keyboards-shr/LICENSE
> >> >> >
> >> >> > diff --git a/meta-efl/recipes-efl/e17/illume-keyboards-shr/LICENSE b/meta-efl/recipes-efl/e17/illume-keyboards-shr/LICENSE
> >> >> > new file mode 100644
> >> >> > index 0000000..61bb2f6
> >> >> > --- /dev/null
> >> >> > +++ b/meta-efl/recipes-efl/e17/illume-keyboards-shr/LICENSE
> >> >> > @@ -0,0 +1,25 @@
> >> >> > +Copyright notice for Enlightenment:
> >> >> > +
> >> >> > +Copyright (C) 2000-2010 Carsten Haitzler and various contributors (see AUTHORS)
> >> >> > +
> >> >> > +All rights reserved.
> >> >> > +
> >> >> > +Redistribution and use in source and binary forms, with or without
> >> >> > +modification, are permitted provided that the following conditions are met:
> >> >> > +
> >> >> > +   1. Redistributions of source code must retain the above copyright
> >> >> > +      notice, this list of conditions and the following disclaimer.
> >> >> > +   2. Redistributions in binary form must reproduce the above copyright
> >> >> > +      notice, this list of conditions and the following disclaimer in the
> >> >> > +      documentation and/or other materials provided with the distribution.
> >> >> > +
> >> >> > +THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
> >> >> > +INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> >> >> > +FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> >> >> > +COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> >> >> > +INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> >> >> > +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
> >> >> > +OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
> >> >> > +LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
> >> >> > +NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
> >> >> > +EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> >> >> > diff --git a/meta-efl/recipes-efl/e17/illume-keyboards-shr_git.bb b/meta-efl/recipes-efl/e17/illume-keyboards-shr_git.bb
> >> >> > index fe34513..e3b182d 100644
> >> >> > --- a/meta-efl/recipes-efl/e17/illume-keyboards-shr_git.bb
> >> >> > +++ b/meta-efl/recipes-efl/e17/illume-keyboards-shr_git.bb
> >> >> > @@ -1,15 +1,16 @@
> >> >> >  SECTION = "x11/data"
> >> >> >
> >> >> >  SRC_URI = "git://git.shr-project.org/repo/illume-keyboards.git;protocol=http;branch=master \
> >> >> > -           file://0001-Makefile-update-KEYBOARDS_DIR-for-new-illume2.patch"
> >> >> > +           file://0001-Makefile-update-KEYBOARDS_DIR-for-new-illume2.patch \
> >> >> > +          file://LICENSE"
> >> >> >  S = "${WORKDIR}/git"
> >> >> >
> >> >> >  SRCREV = "4064489f359a1addf572089b582f317dff5f50e1"
> >> >> >  PV = "0.0+gitr${SRCPV}"
> >> >> >  PE = "1"
> >> >> >  PR = "r4"
> >> >> > -LICENSE = "unknown"
> >> >> > -
> >> >> > +LICENSE = "MIT BSD"
> >> >> > +LIC_FILES_CHKSUM = "file://${WORKDIR}/LICENSE;md5=f523ab5986cc79b52a90d2ac3d5454a2"
> >> >> >
> >> >> >  PACKAGES = "\
> >> >> >  illume-keyboard-alpha \
> >> >> > --
> >> >> > 1.7.4.1
> >> >> >
> >> >> >
> >> >> > _______________________________________________
> >> >> > Openembedded-devel mailing list
> >> >> > Openembedded-devel at lists.openembedded.org
> >> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >> >> >
> >> >
> >> > --
> >> > Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
> >> >
> >
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110331/bdbf7db7/attachment-0002.sig>