[oe] [PATCH] u-boot_git: Ethernet MACID display fix for CraneBoard
Anil Kumar Mamidala
anilm at mistralsolutions.com
Fri May 6 09:36:55 UTC 2011
Hi Paul,
Thanks for your quick feedback. I am sorry. From my next submissions i will
keep your comments in mind.
Here is my Signed-off .
Signed-off-by: Anil Kumar <anilm at mistralsolutions.com>
This patch was not send to upstream.
> Dear Anil,
>
>
> thank you for the next version.
>
> Am Freitag, den 06.05.2011, 12:45 +0530 schrieb Anil Kumar:
> > CraneBoard u-boot displays the MAC ID wrongly if MAC ID has
> > preceding zeros. This patch fixes it and updates Ethernet
> > NRST GPIO from 34 to 65.
>
> Unfortunately you forgot to add your Signed-off-by line. You do not need to
> resend the patch, but just reply to this message with the line.
>
> One question though you did not answer.
>
> 1. Did you send this patch upstream?
>
> Some more remarks for the future.
>
> 2. Please mark patch iteration with version information. This patch should
> have had »[PATCH v2]« in the subject.
> 3. The commit message does not have to be indented.
> 4. Please add below the »---« a short information what changed in the patch
> iteration, like
>
> v2: add commit message
> and finish this by an additional »---«.
>
> > ---
> > ...t-MACID-display-fix-for-am3517-craneboard.patch | 108
> ++++++++++++++++++++
> > recipes/u-boot/u-boot_git.bb | 3 +-
> > 2 files changed, 110 insertions(+), 1 deletions(-) create mode
> > 100644
> > recipes/u-boot/u-boot-git/am3517-crane/0004-Ethernet-MACID-display-fix
> > -for-am3517-craneboard.patch
>
> […]
>
> Koen, will you push this or do you want me to do this?
>
>
> Thank you,
>
> Paul
>
--
Thanks and Regards
Anil kumar.M
More information about the Openembedded-devel
mailing list