[oe] [meta-oe][PATCH] conf/layer.conf: Use .= for BBPATH and += for BBFILES

[Khem Raj]

On Fri, May 6, 2011 at 12:29 AM, Phil Blundell <philb at gnu.org> wrote:
> On Thu, 2011-05-05 at 20:47 -0700, raj.khem at gmail.com wrote:
>>  # We have a conf and classes directory, prepend to BBPATH to prefer our versions
>> -BBPATH := "${LAYERDIR}:${BBPATH}"
>> +BBPATH .= ":${LAYERDIR}"
>
> This patch seems to cause the code to do the opposite of what the
> comment says.  If changing it to be an append rather than a prepend is
> deliberate, please adjust the comment to match.  (It would also be nice
> to have some commentary in the commit message explaining why this is
> being done, since it isn't obvious to me why append would be better.)
>
That comment should be fixed. Since previously I has prepend and then
changed it to append but forgot
to correct the comment.
It needed to follow some order for consistency and I chose append. Now
it depends on the order of
layers specified in BBLAYERS from bblayer.conf. Which means 1st entry
gets priority
over second entry when bitbake searches BBPATH. Right now there are
two criteria's
BBFILES are selected per priority set by BBFILES_PRIORITY for the
layer but BBPATHs dont have this
capability they get searched as they appear in the list.  Ideally I
would think it would be simpler to have just one order for BBFILES and
BBPATH
so if BBPATHS followed the BBFILES priority too would make it easier
to comprehend.


> p.
>
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>