[oe] [PATCH 08/12] matchbox-panel: depend on xterm(matchbox panel contain an xterm launcher)
Phil Blundell
philb at gnu.org
Sun May 15 20:32:28 UTC 2011
On Sun, 2011-05-15 at 22:04 +0200, Florian Boor wrote:
> Hi,
>
> Am 13.05.2011 14:43, schrieb Denis 'GNUtoo' Carikli:
> > +RDEPENDS += "xterm"
>
> I do not like this one. I have been using matchbox-panel for many years without
> having xterm installed.
Agreed, it should be RRECOMMENDS. Also, whatever kind of dependency is
used, it should be applied only to ${PN} and not all subpackages.
Setting plain RDEPENDS is almost always an error, and I'm fairly sure
there is a QA diagnostic for this. So, if this kind of thing shows up
in a submitted patch it always makes me question whether the patch has
actually been tested or not.
p.
More information about the Openembedded-devel
mailing list