[oe] [PATCH] fix acpid compiler warning on some platforms

[Christian Betz]

Signed-off-by: Christian Betz <christian.betz at gmail.com>
---------------------------------------------------------
I'm sorry I missed the part about officially signing off.

Would you mind telling me the sequence of git format-patch and git
send-email that you typically use?

This is what I plan to do next time

  git format-patch -s 2b621ed98259fa87b2e7ad05d4787d2dbf618608
  git send-email --annotate 0001-fix-something.patch

I will put the commit message as the subject and then detail why the
fix is needed in my editor in annotate mode.

Or maybe there is an official wiki document you (someone) can point me to?

Christian


On Sun, May 15, 2011 at 6:41 AM, Paul Menzel
<paulepanter at users.sourceforge.net> wrote:
> Dear Christian,
>
>
> Am Sonntag, den 15.05.2011, 00:16 -0400 schrieb Christian Betz:
>
> thank you for your fast response. Next time please also add the commit
> message. The one you provided in your first message would have been
> enough. You can even change/improve commit messages using `git commit
> --amend` (or `git rebase …`) before doing `git format-patch …`.
>
> I will add the commit message when applying your patch.
>
> You also forgot your Signed-off-by line. Please reply to this message
> with just that line since it is required by our commit policy.
>
> Passing `-s` to `git commit` or `git format-patch` adds that line
> automatically to  the commit message.
>
>> ---
>>  recipes/acpid/acpid-1.0.10/netlink.diff |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/acpid/acpid-1.0.10/netlink.diff b/recipes/acpid/acpid-1.0.10/netlink.diff
>> index 635c550..ebdec58 100644
>> --- a/recipes/acpid/acpid-1.0.10/netlink.diff
>> +++ b/recipes/acpid/acpid-1.0.10/netlink.diff
>> @@ -2019,7 +2019,7 @@ diff -ruN acpid-1.0.10/libnetlink.c acpid-1.0.10-netlink2/libnetlink.c
>>  +
>>  +int addraw_l(struct nlmsghdr *n, int maxlen, const void *data, int len)
>>  +{
>> -+    if ((int)NLMSG_ALIGN(n->nlmsg_len) + NLMSG_ALIGN(len) > maxlen) {
>> ++    if ((int)NLMSG_ALIGN(n->nlmsg_len) + (int)NLMSG_ALIGN(len) > maxlen) {
>>  +            fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
>>  +            return -1;
>>  +    }
>
>
> Thanks,
>
> Paul
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>



-- 
For there are moments when one can neither think nor feel.  And if one
can neither think nor feel, she thought, where is one?
 -- Virginia Woolf, "To the Lighthouse"

[Quoted in "VMS Internals and Data Structures", V4.4, when referring
to powerfail recovery.]