[oe] [PATCH] wpa-gui-e: build the latest version from git sources

[Paul Menzel]

Dear Eyal,


please check your `git send-email` setup. Somehow it has the following
in the massage header

        In-Reply-To: <y>
        References: <y>

and your message from Wednesday (Wed, 18 May 2011 16:37:23 +0200) does
too.

        References: <y> <1305614722-5460-1-git-send-email-eyalr at ti.com>
        In-Reply-To: <1305614722-5460-1-git-send-email-eyalr at ti.com>

Therefore the threading gets messed up.

On Mi, 2011-05-25 at 15:58 +0300, Eyal Reizer wrote:
> Builds wpa-gui for qt4-embedded from the latest wpa-supplicant (0.8x)
> git sources

Which build configuration did you use for testing?

> Signed-off-by: Eyal Reizer <eyalr at ti.com>
> ---
>  recipes/wpa-supplicant/wpa-gui-e_git.bb |   32 +++++++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/wpa-supplicant/wpa-gui-e_git.bb
> 
> diff --git a/recipes/wpa-supplicant/wpa-gui-e_git.bb b/recipes/wpa-supplicant/wpa-gui-e_git.bb
> new file mode 100644
> index 0000000..1c990c6
> --- /dev/null
> +++ b/recipes/wpa-supplicant/wpa-gui-e_git.bb

The other recipes are named just `wpa-gui_….bb`. Why `-e` and not
`-qt4`?

> @@ -0,0 +1,32 @@
> +DESCRIPTION = "Qt embedded interface for choosing which configured network \
> +to connect to. It also provides a method for browsing 802.11 SSID scan \
> +results, an event history log of messages generated by wpa_supplicant, and \
> +a method to add or edit wpa_supplicant networks."
> +SECTION = "network"
> +LICENSE = "GPL BSD"
> +HOMEPAGE = "http://hostap.epitest.fi/wpa_supplicant/"
> +RDEPENDS_${PN} = "wpa-supplicant"
> +RRECOMMENDS_${PN} = "glibc-gconv-utf-16"

Please order the variables according to the style guide [1].

> +
> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> +PR = "r0"
> +PV = "0.7.3+0.8.0-rc"
> +PR_append = "+gitr${SRCPV}"
> +
> +DEFAULT_PREFERENCE = "-1"

Since it is a new recipe name and not packaged yet and `PROVIDES` is not
set, I guess you can leave `DP = "-1"` out.

> +
> +SRC_URI = "git://w1.fi/srv/git/hostap.git;protocol=git"
> +
> +S = "${WORKDIR}/git/wpa_supplicant/wpa_gui-qt4"
> +
> +inherit qt4e
> +ARM_INSTRUCTION_SET = "arm"
> +
> +do_install () {
> +       install -d ${D}${bindir}
> +       install -d ${D}${datadir}/wpa_gui
> +       install -d ${D}${datadir}/applications
> +       install -m 755 wpa_gui ${D}/${bindir}/wpa_gui-e
> +}
> +
> +

You do not need the last two empty lines.

If you have some time you could create an include file and build test
and remove old `wpa-gui` versions.


Thanks,

Paul


[1] http://openembedded.org/index.php/Styleguide
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110525/b7cbec67/attachment-0002.sig>