[oe] [PATCH] wpa-gui-e: build the latest version from git sources

[Martin Jansa]

On Wed, May 25, 2011 at 04:18:20PM +0200, Reizer, Eyal wrote:
> Koen,
> 
> Do you mean that using SRCREV instead of SRCPV as below is ok, or should I also remove the PV = "..."?
> 
> +PV = "0.7.3+0.8.0-rc"
> +PR_append = "+git${SRCREV}"

Please stay with ${SRCPV} and +gitr (not +git) if you care about
upgradable paths.

And I don't care if it's in PV or PR and I use it from PR sometimes too,
because it's easier to put ie patches to ${PN}-${PV} dir like
wpa-gui-e-0.7.3+0.8.0-rc/foo.path
and better (even faster for ricers) then shared wpa-gui-e/foo.path

Regards,

> > -----Original Message-----
> > From: openembedded-devel-bounces at lists.openembedded.org
> > [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
> > Koen Kooi
> > Sent: Wednesday, May 25, 2011 5:13 PM
> > To: openembedded-devel at lists.openembedded.org
> > Subject: Re: [oe] [PATCH] wpa-gui-e: build the latest version from git
> > sources
> > 
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > On 25-05-11 16:03, Paul Menzel wrote:
> > > Dear Andreas, dear Eyal,
> > >
> > >
> > > On Mi, 2011-05-25 at 15:36 +0200, Andreas Oberritter wrote:
> > >
> > >> On 05/25/2011 02:58 PM, Eyal Reizer wrote:
> > >
> > > […]
> > >
> > >>> +SRCREV = "b8fb017272ed4794339978c9fbc0e74571a44728"
> > >>> +PR = "r0"
> > >>
> > >> PR = "r0" is the default and can be removed.
> > >
> > > it seems there are different opinions on this topic. At least the
> > manual
> > > says differently.
> > >
> > >         Note
> > >
> > >         It is good practice to always define PR in your recipes, even
> > >         for the "r0" release, so that when editing the recipe it is
> > >         clear that the PR number needs to be updated.
> > >
> > >         You should always increment PR when modifying a recipe.
> > >         Sometimes this can be avoided if the change will have no
> > effect
> > >         on the actual packages generated by the recipe, such as
> > updating
> > >         the SRC_URI to point to a new host. If in any doubt then you
> > >         should increase the PR regardless of what has been changed.
> > >
> > >         The PR value should never be decremented. If you accidentally
> > >         submit a large PR value for example then it should be left at
> > >         the value and just increased for new releases, not reset back
> > to
> > >         a lower version.
> > >
> > >>> +PV = "0.7.3+0.8.0-rc"
> > >>> +PR_append = "+gitr${SRCPV}"
> > >>
> > >> SRCPV should not be used in PR (even if it's been copied from
> > another
> > >> recipe which does it wrong).
> > >
> > > I am still confused about this one. That is why I still have not
> > > committed the pkg-config patch yet [2]. Could the right way be
> > > documented in the manual.
> > 
> > It is completely OK to use it in PR if you want the hash in PR, but not
> > PV.
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.5 (Darwin)
> > 
> > iD8DBQFN3Q5dMkyGM64RGpERAhwhAKCKxo/HdbjYY90JHWbgtyiGCMwLFQCgiaRa
> > HB1AMRMFaS/r4+iF6S6wa5M=
> > =XI4d
> > -----END PGP SIGNATURE-----
> > 
> > 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110525/749810ea/attachment-0002.sig>